tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

gpio: bd7xxxx: use helper variable for pdev->dev

Using a helper local variable to store the address of &pdev->dev adds
to readability and allows us to avoid unnecessary line breaks.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Reviewed-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>

Bartosz Golaszewski cb38cd70 66fecef5

+15 -17
+8 -9
drivers/gpio/gpio-bd70528.c
··· 181 181 182 182 static int bd70528_probe(struct platform_device *pdev) 183 183 { 184 + struct device *dev = &pdev->dev; 184 185 struct bd70528_gpio *bdgpio; 185 186 int ret; 186 187 187 - bdgpio = devm_kzalloc(&pdev->dev, sizeof(*bdgpio), 188 - GFP_KERNEL); 188 + bdgpio = devm_kzalloc(dev, sizeof(*bdgpio), GFP_KERNEL); 189 189 if (!bdgpio) 190 190 return -ENOMEM; 191 - bdgpio->dev = &pdev->dev; 192 - bdgpio->gpio.parent = pdev->dev.parent; 191 + bdgpio->dev = dev; 192 + bdgpio->gpio.parent = dev->parent; 193 193 bdgpio->gpio.label = "bd70528-gpio"; 194 194 bdgpio->gpio.owner = THIS_MODULE; 195 195 bdgpio->gpio.get_direction = bd70528_get_direction; ··· 202 202 bdgpio->gpio.ngpio = 4; 203 203 bdgpio->gpio.base = -1; 204 204 #ifdef CONFIG_OF_GPIO 205 - bdgpio->gpio.of_node = pdev->dev.parent->of_node; 205 + bdgpio->gpio.of_node = dev->parent->of_node; 206 206 #endif 207 - bdgpio->regmap = dev_get_regmap(pdev->dev.parent, NULL); 207 + bdgpio->regmap = dev_get_regmap(dev->parent, NULL); 208 208 if (!bdgpio->regmap) 209 209 return -ENODEV; 210 210 211 - ret = devm_gpiochip_add_data(&pdev->dev, &bdgpio->gpio, 212 - bdgpio); 211 + ret = devm_gpiochip_add_data(dev, &bdgpio->gpio, bdgpio); 213 212 if (ret) 214 - dev_err(&pdev->dev, "gpio_init: Failed to add bd70528-gpio\n"); 213 + dev_err(dev, "gpio_init: Failed to add bd70528-gpio\n"); 215 214 216 215 return ret; 217 216 }
+7 -8
drivers/gpio/gpio-bd71828.c
··· 97 97 98 98 static int bd71828_probe(struct platform_device *pdev) 99 99 { 100 + struct device *dev = &pdev->dev; 100 101 struct bd71828_gpio *bdgpio; 101 102 102 - bdgpio = devm_kzalloc(&pdev->dev, sizeof(*bdgpio), 103 - GFP_KERNEL); 103 + bdgpio = devm_kzalloc(dev, sizeof(*bdgpio), GFP_KERNEL); 104 104 if (!bdgpio) 105 105 return -ENOMEM; 106 106 107 - bdgpio->dev = &pdev->dev; 108 - bdgpio->gpio.parent = pdev->dev.parent; 107 + bdgpio->dev = dev; 108 + bdgpio->gpio.parent = dev->parent; 109 109 bdgpio->gpio.label = "bd71828-gpio"; 110 110 bdgpio->gpio.owner = THIS_MODULE; 111 111 bdgpio->gpio.get_direction = bd71828_get_direction; ··· 121 121 * "gpio-reserved-ranges" and exclude them from control 122 122 */ 123 123 bdgpio->gpio.ngpio = 4; 124 - bdgpio->gpio.of_node = pdev->dev.parent->of_node; 125 - bdgpio->regmap = dev_get_regmap(pdev->dev.parent, NULL); 124 + bdgpio->gpio.of_node = dev->parent->of_node; 125 + bdgpio->regmap = dev_get_regmap(dev->parent, NULL); 126 126 if (!bdgpio->regmap) 127 127 return -ENODEV; 128 128 129 - return devm_gpiochip_add_data(&pdev->dev, &bdgpio->gpio, 130 - bdgpio); 129 + return devm_gpiochip_add_data(dev, &bdgpio->gpio, bdgpio); 131 130 } 132 131 133 132 static struct platform_driver bd71828_gpio = {