tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

drm: Remove unused fbdev_list members

I noticed that intel_fbdev->our_mode is unused. Introduced by
79e539453b34 ("DRM: i915: add mode setting support").

Then I noticed that intel_fbdev->fbdev_list is unused as well.
Introduced by 386516744ba4 ("drm/fb: fix fbdev object model +
cleanup properly.") in i915, nouveau and radeon.

Subsequently cargo culted to amdgpu, ast, cirrus, qxl, udl,
virtio and mgag200.

Already removed from the latter with cc59487a05b1 ("drm/mgag200:
'fbdev_list' in 'struct mga_fbdev' is not used").

Remove it from the others.

Signed-off-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

authored by

Lukas Wunner and committed by
Daniel Vetter cb119717 5f911905

-10
-1
drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
··· 45 45 struct amdgpu_fbdev { 46 46 struct drm_fb_helper helper; 47 47 struct amdgpu_framebuffer rfb; 48 - struct list_head fbdev_list; 49 48 struct amdgpu_device *adev; 50 49 }; 51 50
-1
drivers/gpu/drm/ast/ast_drv.h
··· 256 256 struct ast_fbdev { 257 257 struct drm_fb_helper helper; 258 258 struct ast_framebuffer afb; 259 - struct list_head fbdev_list; 260 259 void *sysram; 261 260 int size; 262 261 struct ttm_bo_kmap_obj mapping;
-1
drivers/gpu/drm/cirrus/cirrus_drv.h
··· 153 153 struct cirrus_fbdev { 154 154 struct drm_fb_helper helper; 155 155 struct cirrus_framebuffer gfb; 156 - struct list_head fbdev_list; 157 156 void *sysram; 158 157 int size; 159 158 int x1, y1, x2, y2; /* dirty rect */
-2
drivers/gpu/drm/i915/intel_drv.h
··· 123 123 struct intel_fbdev { 124 124 struct drm_fb_helper helper; 125 125 struct intel_framebuffer *fb; 126 - struct list_head fbdev_list; 127 - struct drm_display_mode *our_mode; 128 126 int preferred_bpp; 129 127 }; 130 128
-1
drivers/gpu/drm/nouveau/nouveau_fbcon.h
··· 34 34 struct nouveau_fbdev { 35 35 struct drm_fb_helper helper; 36 36 struct nouveau_framebuffer nouveau_fb; 37 - struct list_head fbdev_list; 38 37 struct drm_device *dev; 39 38 unsigned int saved_flags; 40 39 struct nvif_object surf2d;
-1
drivers/gpu/drm/qxl/qxl_fb.c
··· 40 40 struct qxl_fbdev { 41 41 struct drm_fb_helper helper; 42 42 struct qxl_framebuffer qfb; 43 - struct list_head fbdev_list; 44 43 struct qxl_device *qdev; 45 44 46 45 spinlock_t delayed_ops_lock;
-1
drivers/gpu/drm/radeon/radeon_fb.c
··· 44 44 struct radeon_fbdev { 45 45 struct drm_fb_helper helper; 46 46 struct radeon_framebuffer rfb; 47 - struct list_head fbdev_list; 48 47 struct radeon_device *rdev; 49 48 }; 50 49
-1
drivers/gpu/drm/udl/udl_fb.c
··· 33 33 struct udl_fbdev { 34 34 struct drm_fb_helper helper; 35 35 struct udl_framebuffer ufb; 36 - struct list_head fbdev_list; 37 36 int fb_count; 38 37 }; 39 38
-1
drivers/gpu/drm/virtio/virtgpu_fb.c
··· 32 32 struct virtio_gpu_fbdev { 33 33 struct drm_fb_helper helper; 34 34 struct virtio_gpu_framebuffer vgfb; 35 - struct list_head fbdev_list; 36 35 struct virtio_gpu_device *vgdev; 37 36 struct delayed_work work; 38 37 };