Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/i915/guc: fix comment about fallback to execlists

We stopped supporting fallback to execlists in commit 121981fafe69
(drm/i915/guc: Combine enable_guc_loading|submission modparams). We
do instead reset and retry in some cases, depending on the workarounds
required by the platform.

Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20181022230427.5616-4-daniele.ceraolospurio@intel.com

authored by

Daniele Ceraolo Spurio and committed by
Chris Wilson
caef29cd fb0c37f6

+2 -2
+2 -2
drivers/gpu/drm/i915/intel_guc_fw.c
··· 217 217 * NB: Docs recommend not using the interrupt for completion. 218 218 * Measurements indicate this should take no more than 20ms, so a 219 219 * timeout here indicates that the GuC has failed and is unusable. 220 - * (Higher levels of the driver will attempt to fall back to 221 - * execlist mode if this happens.) 220 + * (Higher levels of the driver may decide to reset the GuC and 221 + * attempt the ucode load again if this happens.) 222 222 */ 223 223 ret = wait_for(guc_ready(guc, &status), 100); 224 224 DRM_DEBUG_DRIVER("GuC status %#x\n", status);