Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Input: gpio_keys_polled - simplify with dev_err_probe()

Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20230625162817.100397-2-krzysztof.kozlowski@linaro.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

authored by

Krzysztof Kozlowski and committed by
Dmitry Torokhov
caec3d44 0d384e59

+2 -6
+2 -6
drivers/input/keyboard/gpio_keys_polled.c
··· 299 299 NULL, GPIOD_IN, 300 300 button->desc); 301 301 if (IS_ERR(bdata->gpiod)) { 302 - error = PTR_ERR(bdata->gpiod); 303 - if (error != -EPROBE_DEFER) 304 - dev_err(dev, 305 - "failed to get gpio: %d\n", 306 - error); 307 302 fwnode_handle_put(child); 308 - return error; 303 + return dev_err_probe(dev, PTR_ERR(bdata->gpiod), 304 + "failed to get gpio\n"); 309 305 } 310 306 } else if (gpio_is_valid(button->gpio)) { 311 307 /*