Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

i3c: Fix potential refcount leak in i3c_master_register_new_i3c_devs

put_device() needs to be called on failure of device_register()
to give up the reference initialized in it to avoid refcount leak.

Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20230921082410.25548-1-dinghao.liu@zju.edu.cn
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

authored by

Dinghao Liu and committed by
Alexandre Belloni
cab63f64 fc9176e7

+3 -1
+3 -1
drivers/i3c/master.c
··· 1525 1525 desc->dev->dev.of_node = desc->boardinfo->of_node; 1526 1526 1527 1527 ret = device_register(&desc->dev->dev); 1528 - if (ret) 1528 + if (ret) { 1529 1529 dev_err(&master->dev, 1530 1530 "Failed to add I3C device (err = %d)\n", ret); 1531 + put_device(&desc->dev->dev); 1532 + } 1531 1533 } 1532 1534 } 1533 1535