Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

alpha: Send stop IPI to send to online CPUs

This issue was noticed while debugging a shutdown issue where some
secondary CPUs are not being shutdown correctly. A fix for that [1] requires
that secondary cpus be offlined using the cpu_online_mask so that the
stop operation is a no-op if CPU HOTPLUG is disabled. I, like the author in
[1] looked at the architectures and found that alpha is one of two
architectures that executes smp_send_stop() on all possible CPUs.

On alpha, smp_send_stop() sends an IPI to all possible CPUs but only needs
to send them to online CPUs.

Send the stop IPI to only the online CPUs.

[1] https://lkml.org/lkml/2020/1/10/250

Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Signed-off-by: Matt Turner <mattst88@gmail.com>

authored by

Prarit Bhargava and committed by
Matt Turner
caace6ca f0443da1

+1 -1
+1 -1
arch/alpha/kernel/smp.c
··· 582 582 smp_send_stop(void) 583 583 { 584 584 cpumask_t to_whom; 585 - cpumask_copy(&to_whom, cpu_possible_mask); 585 + cpumask_copy(&to_whom, cpu_online_mask); 586 586 cpumask_clear_cpu(smp_processor_id(), &to_whom); 587 587 #ifdef DEBUG_IPI_MSG 588 588 if (hard_smp_processor_id() != boot_cpu_id)