Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbdev: Fix order of arguments to aperture_remove_conflicting_devices()

Reverse the order of the final two arguments when calling
aperture_remove_conflicting_devices(). An error report is available
at [1].

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: 8d69d008f44c ("fbdev: Convert drivers to aperture helpers")
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Michael Kelley <mikelley@microsoft.com> # hypervfb
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Javier Martinez Canillas <javierm@redhat.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Teddy Wang <teddy.wang@siliconmotion.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: Wei Liu <wei.liu@kernel.org>
Cc: Dexuan Cui <decui@microsoft.com>
Cc: linux-fbdev@vger.kernel.org
Cc: linux-hyperv@vger.kernel.org
Link: https://lore.kernel.org/lkml/202207202040.jS1WcTzN-lkp@intel.com/ # 1
Link: https://patchwork.freedesktop.org/patch/msgid/20220721081655.16128-1-tzimmermann@suse.de

+2 -2
+1 -1
drivers/video/fbdev/aty/radeon_base.c
··· 2243 2243 resource_size_t base = pci_resource_start(pdev, 0); 2244 2244 resource_size_t size = pci_resource_len(pdev, 0); 2245 2245 2246 - return aperture_remove_conflicting_devices(base, size, KBUILD_MODNAME, false); 2246 + return aperture_remove_conflicting_devices(base, size, false, KBUILD_MODNAME); 2247 2247 } 2248 2248 2249 2249 static int radeonfb_pci_register(struct pci_dev *pdev,
+1 -1
drivers/video/fbdev/hyperv_fb.c
··· 1077 1077 getmem_done: 1078 1078 aperture_remove_conflicting_devices(info->apertures->ranges[0].base, 1079 1079 info->apertures->ranges[0].size, 1080 - KBUILD_MODNAME, false); 1080 + false, KBUILD_MODNAME); 1081 1081 1082 1082 if (gen2vm) { 1083 1083 /* framebuffer is reallocated, clear screen_info to avoid misuse from kexec */