Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[SCSI] zfcp: remove invalid reference to list iterator variable

If list_for_each_entry, etc complete a traversal of the list, the iterator
variable ends up pointing to an address at an offset from the list head,
and not a meaningful structure. Thus this value should not be used after
the end of the iterator. Replace port->adapter->scsi_host by
adapter->scsi_host.

This problem was found using Coccinelle (http://coccinelle.lip6.fr/).

Oversight in upsteam commit of v2.6.37
a1ca48319a9aa1c5b57ce142f538e76050bb8972
"[SCSI] zfcp: Move ACL/CFDC code to zfcp_cfdc.c"
which merged the content of zfcp_erp_port_access_changed().

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Reviewed-by: Martin Peschke <mpeschke@linux.vnet.ibm.com>
Cc: <stable@vger.kernel.org> #2.6.37+
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

authored by

Julia Lawall and committed by
James Bottomley
ca579c9f cb452149

+1 -1
+1 -1
drivers/s390/scsi/zfcp_cfdc.c
··· 293 293 } 294 294 read_unlock_irqrestore(&adapter->port_list_lock, flags); 295 295 296 - shost_for_each_device(sdev, port->adapter->scsi_host) { 296 + shost_for_each_device(sdev, adapter->scsi_host) { 297 297 zfcp_sdev = sdev_to_zfcp(sdev); 298 298 status = atomic_read(&zfcp_sdev->status); 299 299 if ((status & ZFCP_STATUS_COMMON_ACCESS_DENIED) ||