Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

crypto: omap-sham - Fix PM reference leak in omap sham ops

pm_runtime_get_sync will increment pm usage counter
even it failed. Forgetting to putting operation will
result in reference leak here. We fix it by replacing
it with pm_runtime_resume_and_get to keep usage counter
balanced.

Fixes: 604c31039dae4 ("crypto: omap-sham - Check for return value from pm_runtime_get_sync")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

authored by

Zhang Qilong and committed by
Herbert Xu
ca323b2c d950cd1b

+2 -2
+2 -2
drivers/crypto/omap-sham.c
··· 372 372 { 373 373 int err; 374 374 375 - err = pm_runtime_get_sync(dd->dev); 375 + err = pm_runtime_resume_and_get(dd->dev); 376 376 if (err < 0) { 377 377 dev_err(dd->dev, "failed to get sync: %d\n", err); 378 378 return err; ··· 2244 2244 2245 2245 static int omap_sham_resume(struct device *dev) 2246 2246 { 2247 - int err = pm_runtime_get_sync(dev); 2247 + int err = pm_runtime_resume_and_get(dev); 2248 2248 if (err < 0) { 2249 2249 dev_err(dev, "failed to get sync: %d\n", err); 2250 2250 return err;