Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

gpu/drm: Kill off set_irq_flags usage

set_irq_flags is ARM specific with custom flags which have genirq
equivalents. Convert drivers to use the genirq interfaces directly, so we
can kill off set_irq_flags. The translation of flags is as follows:

IRQF_VALID -> !IRQ_NOREQUEST
IRQF_PROBE -> !IRQ_NOPROBE
IRQF_NOAUTOEN -> IRQ_NOAUTOEN

For IRQs managed by an irqdomain, the irqdomain core code handles clearing
and setting IRQ_NOREQUEST already, so there is no need to do this in
.map() functions and we can simply remove the set_irq_flags calls. Some
users also modify IRQ_NOPROBE and this has been maintained although it
is not clear that is really needed. There appears to be a great deal of
blind copy and paste of this code.

Signed-off-by: Rob Herring <robh@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: Russell King <linux@arm.linux.org.uk>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

authored by

Rob Herring and committed by
Thomas Gleixner
ca0141de bd0b9ac4

+1 -3
-1
drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c
··· 178 178 179 179 irq_set_chip_and_handler(irq, &mdp5_hw_irq_chip, handle_level_irq); 180 180 irq_set_chip_data(irq, mdp5_kms); 181 - set_irq_flags(irq, IRQF_VALID); 182 181 183 182 return 0; 184 183 }
+1 -2
drivers/gpu/ipu-v3/ipu-common.c
··· 1099 1099 } 1100 1100 1101 1101 ret = irq_alloc_domain_generic_chips(ipu->domain, 32, 1, "IPU", 1102 - handle_level_irq, 0, 1103 - IRQF_VALID, 0); 1102 + handle_level_irq, 0, 0, 0); 1104 1103 if (ret < 0) { 1105 1104 dev_err(ipu->dev, "failed to alloc generic irq chips\n"); 1106 1105 irq_domain_remove(ipu->domain);