tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

VM: add common helper function to create the page tables

This logic was duplicated four times, for no good reason.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>

Linus Torvalds c9cfcddf 4168f7a3

+19 -45
unified split
+1 -11
fs/exec.c
··· 306 306 struct page *page, unsigned long address) 307 307 { 308 308 struct mm_struct *mm = vma->vm_mm; 309 - pgd_t * pgd; 310 - pud_t * pud; 311 - pmd_t * pmd; 312 309 pte_t * pte; 313 310 spinlock_t *ptl; 314 311 ··· 313 316 goto out; 314 317 315 318 flush_dcache_page(page); 316 - pgd = pgd_offset(mm, address); 317 - pud = pud_alloc(mm, pgd, address); 318 - if (!pud) 319 - goto out; 320 - pmd = pmd_alloc(mm, pud, address); 321 - if (!pmd) 322 - goto out; 323 - pte = pte_alloc_map_lock(mm, pmd, address, &ptl); 319 + pte = get_locked_pte(mm, address, &ptl); 324 320 if (!pte) 325 321 goto out; 326 322 if (!pte_none(*pte)) {
+2
include/linux/mm.h
··· 742 742 extern struct shrinker *set_shrinker(int, shrinker_t); 743 743 extern void remove_shrinker(struct shrinker *shrinker); 744 744 745 + extern pte_t *FASTCALL(get_locked_pte(struct mm_struct *mm, unsigned long addr, spinlock_t **ptl)); 746 + 745 747 int __pud_alloc(struct mm_struct *mm, pgd_t *pgd, unsigned long address); 746 748 int __pmd_alloc(struct mm_struct *mm, pud_t *pud, unsigned long address); 747 749 int __pte_alloc(struct mm_struct *mm, pmd_t *pmd, unsigned long address);
+2 -22
mm/fremap.c
··· 55 55 pgoff_t size; 56 56 int err = -ENOMEM; 57 57 pte_t *pte; 58 - pmd_t *pmd; 59 - pud_t *pud; 60 - pgd_t *pgd; 61 58 pte_t pte_val; 62 59 spinlock_t *ptl; 63 60 64 - pgd = pgd_offset(mm, addr); 65 - pud = pud_alloc(mm, pgd, addr); 66 - if (!pud) 67 - goto out; 68 - pmd = pmd_alloc(mm, pud, addr); 69 - if (!pmd) 70 - goto out; 71 - pte = pte_alloc_map_lock(mm, pmd, addr, &ptl); 61 + pte = get_locked_pte(mm, addr, &ptl); 72 62 if (!pte) 73 63 goto out; 74 64 ··· 100 110 { 101 111 int err = -ENOMEM; 102 112 pte_t *pte; 103 - pmd_t *pmd; 104 - pud_t *pud; 105 - pgd_t *pgd; 106 113 pte_t pte_val; 107 114 spinlock_t *ptl; 108 115 109 - pgd = pgd_offset(mm, addr); 110 - pud = pud_alloc(mm, pgd, addr); 111 - if (!pud) 112 - goto out; 113 - pmd = pmd_alloc(mm, pud, addr); 114 - if (!pmd) 115 - goto out; 116 - pte = pte_alloc_map_lock(mm, pmd, addr, &ptl); 116 + pte = get_locked_pte(mm, addr, &ptl); 117 117 if (!pte) 118 118 goto out; 119 119
+14 -12
mm/memory.c
··· 1146 1146 return err; 1147 1147 } 1148 1148 1149 + pte_t *get_locked_pte(struct mm_struct *mm, unsigned long addr, spinlock_t **ptl) 1150 + { 1151 + pgd_t * pgd = pgd_offset(mm, addr); 1152 + pud_t * pud = pud_alloc(mm, pgd, addr); 1153 + if (pud) { 1154 + pmd_t * pmd = pmd_alloc(mm, pgd, addr); 1155 + if (pmd) 1156 + return pte_alloc_map_lock(mm, pmd, addr, ptl); 1157 + } 1158 + return NULL; 1159 + } 1160 + 1149 1161 /* 1150 1162 * This is the old fallback for page remapping. 1151 1163 * ··· 1168 1156 static int insert_page(struct mm_struct *mm, unsigned long addr, struct page *page, pgprot_t prot) 1169 1157 { 1170 1158 int retval; 1171 - pgd_t * pgd; 1172 - pud_t * pud; 1173 - pmd_t * pmd; 1174 - pte_t * pte; 1159 + pte_t *pte; 1175 1160 spinlock_t *ptl; 1176 1161 1177 1162 retval = -EINVAL; ··· 1176 1167 goto out; 1177 1168 retval = -ENOMEM; 1178 1169 flush_dcache_page(page); 1179 - pgd = pgd_offset(mm, addr); 1180 - pud = pud_alloc(mm, pgd, addr); 1181 - if (!pud) 1182 - goto out; 1183 - pmd = pmd_alloc(mm, pud, addr); 1184 - if (!pmd) 1185 - goto out; 1186 - pte = pte_alloc_map_lock(mm, pmd, addr, &ptl); 1170 + pte = get_locked_pte(mm, addr, &ptl); 1187 1171 if (!pte) 1188 1172 goto out; 1189 1173 retval = -EBUSY;