Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/panel: osd-osd101t2587-53ts: Don't call unprepare+disable at shutdown/remove

It's the responsibility of a correctly written DRM modeset driver to
call drm_atomic_helper_shutdown() at shutdown time and that should be
disabling / unpreparing the panel if needed. Panel drivers shouldn't
be calling these functions themselves.

A recent effort was made to fix as many DRM modeset drivers as
possible [1] [2] [3] and most drivers are fixed now.

A grep through mainline for compatible strings used by this driver
indicates that it is used by TI OMAP boards. The OMAP driver appears
to be correctly calling drm_atomic_helper_shutdown() so we can remove
the calls.

[1] https://lore.kernel.org/r/20230901234015.566018-1-dianders@chromium.org
[2] https://lore.kernel.org/r/20230901234202.566951-1-dianders@chromium.org
[3] https://lore.kernel.org/r/20230921192749.1542462-1-dianders@chromium.org

Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20240604172305.v3.8.Ic533ce1323b94230d4155f9364c2b7c1bc47e798@changeid
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240604172305.v3.8.Ic533ce1323b94230d4155f9364c2b7c1bc47e798@changeid

authored by

Douglas Anderson and committed by
Neil Armstrong
c99e387a 9a3f7eb7

-14
-14
drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
··· 186 186 struct osd101t2587_panel *osd101t2587 = mipi_dsi_get_drvdata(dsi); 187 187 int ret; 188 188 189 - ret = drm_panel_disable(&osd101t2587->base); 190 - if (ret < 0) 191 - dev_warn(&dsi->dev, "failed to disable panel: %d\n", ret); 192 - 193 - drm_panel_unprepare(&osd101t2587->base); 194 189 drm_panel_remove(&osd101t2587->base); 195 190 196 191 ret = mipi_dsi_detach(dsi); 197 192 if (ret < 0) 198 193 dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", ret); 199 - } 200 - 201 - static void osd101t2587_panel_shutdown(struct mipi_dsi_device *dsi) 202 - { 203 - struct osd101t2587_panel *osd101t2587 = mipi_dsi_get_drvdata(dsi); 204 - 205 - drm_panel_disable(&osd101t2587->base); 206 - drm_panel_unprepare(&osd101t2587->base); 207 194 } 208 195 209 196 static struct mipi_dsi_driver osd101t2587_panel_driver = { ··· 200 213 }, 201 214 .probe = osd101t2587_panel_probe, 202 215 .remove = osd101t2587_panel_remove, 203 - .shutdown = osd101t2587_panel_shutdown, 204 216 }; 205 217 module_mipi_dsi_driver(osd101t2587_panel_driver); 206 218