Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

platform/x86: hp_accel: Fix an error handling path in 'lis3lv02d_probe()'

If 'led_classdev_register()' fails, some additional resources should be
released.

Add the missing 'i8042_remove_filter()' and 'lis3lv02d_remove_fs()' calls
that are already in the remove function but are missing here.

Fixes: a4c724d0723b ("platform: hp_accel: add a i8042 filter to remove HPQ6000 data from kb bus stream")
Fixes: 9e0c79782143 ("lis3lv02d: merge with leds hp disk")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/5a4f218f8f16d2e3a7906b7ca3654ffa946895f8.1636314074.git.christophe.jaillet@wanadoo.fr
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

authored by

Christophe JAILLET and committed by
Hans de Goede
c961a7d2 707f0c29

+2
+2
drivers/platform/x86/hp_accel.c
··· 331 331 INIT_WORK(&hpled_led.work, delayed_set_status_worker); 332 332 ret = led_classdev_register(NULL, &hpled_led.led_classdev); 333 333 if (ret) { 334 + i8042_remove_filter(hp_accel_i8042_filter); 334 335 lis3lv02d_joystick_disable(&lis3_dev); 335 336 lis3lv02d_poweroff(&lis3_dev); 336 337 flush_work(&hpled_led.work); 338 + lis3lv02d_remove_fs(&lis3_dev); 337 339 return ret; 338 340 } 339 341