Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

cpufreq: speedstep: remove unnecessary static in speedstep_detect_chipset()

Remove unnecessary static on local variable hostbridge.
Such variable is initialized before being used,
on every execution path throughout the function.
The static has no benefit and, removing it reduces
the code size.

This issue was detected using Coccinelle and the following semantic patch:

@bad exists@
position p;
identifier x;
type T;
@@

static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@

-static
T x@p;
... when != x
when strict
?x = e;

In the following log you can see the difference in the code size. Also,
there is a significant difference in the bss segment. This log is the
output of the size command, before and after the code change:

before:
text data bss dec hex filename
5084 3392 256 8732 221c drivers/cpufreq/speedstep-ich.o

after:
text data bss dec hex filename
5062 3304 192 8558 216e drivers/cpufreq/speedstep-ich.o

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

authored by

Gustavo A. R. Silva and committed by
Rafael J. Wysocki
c95a05f9 5771a8c0

+1 -1
+1 -1
drivers/cpufreq/speedstep-ich.c
··· 207 207 * 8100 which use a pretty old revision of the 82815 208 208 * host bridge. Abort on these systems. 209 209 */ 210 - static struct pci_dev *hostbridge; 210 + struct pci_dev *hostbridge; 211 211 212 212 hostbridge = pci_get_subsys(PCI_VENDOR_ID_INTEL, 213 213 PCI_DEVICE_ID_INTEL_82815_MC,