Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbdev/sisfb: Unexport symbols

Fix the compile-time warning

drivers/video/fbdev/sis/sis_main.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing

The affected symbols are not used outside of their module. Some of
the symbols are not used anywhere, so remove the functions entirely.
Also remove the related, but unused, define SISFB_HAVE_MALLOC_NEW.

v2:
- remove unused functions (Helge)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Helge Deller <deller@gmx.de>
Fixes: a934a57a42f6 ("scripts/misc-check: check missing #include <linux/export.h> when W=1")
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20250612081738.197826-13-tzimmermann@suse.de

-33
-2
drivers/video/fbdev/sis/sis.h
··· 673 673 674 674 /* SiS-specific exported functions */ 675 675 void sis_malloc(struct sis_memreq *req); 676 - void sis_malloc_new(struct pci_dev *pdev, struct sis_memreq *req); 677 676 void sis_free(u32 base); 678 - void sis_free_new(struct pci_dev *pdev, u32 base); 679 677 680 678 /* Routines from init.c/init301.c */ 681 679 extern unsigned short SiS_GetModeID_LCD(int VGAEngine, unsigned int VBFlags, int HDisplay,
-25
drivers/video/fbdev/sis/sis_main.c
··· 3421 3421 req->offset = req->size = 0; 3422 3422 } 3423 3423 3424 - void 3425 - sis_malloc_new(struct pci_dev *pdev, struct sis_memreq *req) 3426 - { 3427 - struct sis_video_info *ivideo = pci_get_drvdata(pdev); 3428 - 3429 - sis_int_malloc(ivideo, req); 3430 - } 3431 - 3432 3424 /* sis_free: u32 because "base" is offset inside video ram, can never be >4GB */ 3433 3425 3434 3426 static void ··· 3443 3451 sis_free(u32 base) 3444 3452 { 3445 3453 struct sis_video_info *ivideo = sisfb_heap->vinfo; 3446 - 3447 - sis_int_free(ivideo, base); 3448 - } 3449 - 3450 - void 3451 - sis_free_new(struct pci_dev *pdev, u32 base) 3452 - { 3453 - struct sis_video_info *ivideo = pci_get_drvdata(pdev); 3454 3454 3455 3455 sis_int_free(ivideo, base); 3456 3456 } ··· 6816 6832 #endif 6817 6833 6818 6834 #endif /* /MODULE */ 6819 - 6820 - /* _GPL only for new symbols. */ 6821 - EXPORT_SYMBOL(sis_malloc); 6822 - EXPORT_SYMBOL(sis_free); 6823 - EXPORT_SYMBOL_GPL(sis_malloc_new); 6824 - EXPORT_SYMBOL_GPL(sis_free_new); 6825 - 6826 - 6827 -
-6
include/video/sisfb.h
··· 15 15 #define SIS_300_VGA 1 16 16 #define SIS_315_VGA 2 17 17 18 - #define SISFB_HAVE_MALLOC_NEW 19 - extern void sis_malloc(struct sis_memreq *req); 20 - extern void sis_malloc_new(struct pci_dev *pdev, struct sis_memreq *req); 21 - 22 - extern void sis_free(u32 base); 23 - extern void sis_free_new(struct pci_dev *pdev, u32 base); 24 18 #endif