Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/panel: jdi-lt070me05000: Don't call disable at shutdown/remove

It's the responsibility of a correctly written DRM modeset driver to
call drm_atomic_helper_shutdown() at shutdown time and that should be
disabling / unpreparing the panel if needed. Panel drivers shouldn't
be calling these functions themselves.

A recent effort was made to fix as many DRM modeset drivers as
possible [1] [2] [3] and most drivers are fixed now.

A grep through mainline for compatible strings used by this driver
indicates that it is used by Qualcomm boards. The Qualcomm driver
appears to be correctly calling drm_atomic_helper_shutdown() so we can
remove the calls.

[1] https://lore.kernel.org/r/20230901234015.566018-1-dianders@chromium.org
[2] https://lore.kernel.org/r/20230901234202.566951-1-dianders@chromium.org
[3] https://lore.kernel.org/r/20230921192749.1542462-1-dianders@chromium.org

Cc: Vinay Simha BN <simhavcs@gmail.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20240604172305.v3.12.I5f3426e511e77b93c247e0aac114bd12b2b2a933@changeid
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240604172305.v3.12.I5f3426e511e77b93c247e0aac114bd12b2b2a933@changeid

authored by

Douglas Anderson and committed by
Neil Armstrong
c8f67cd1 698acd40

-12
-12
drivers/gpu/drm/panel/panel-jdi-lt070me05000.c
··· 452 452 struct jdi_panel *jdi = mipi_dsi_get_drvdata(dsi); 453 453 int ret; 454 454 455 - ret = drm_panel_disable(&jdi->base); 456 - if (ret < 0) 457 - dev_err(&dsi->dev, "failed to disable panel: %d\n", ret); 458 - 459 455 ret = mipi_dsi_detach(dsi); 460 456 if (ret < 0) 461 457 dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", 462 458 ret); 463 459 464 460 jdi_panel_del(jdi); 465 - } 466 - 467 - static void jdi_panel_shutdown(struct mipi_dsi_device *dsi) 468 - { 469 - struct jdi_panel *jdi = mipi_dsi_get_drvdata(dsi); 470 - 471 - drm_panel_disable(&jdi->base); 472 461 } 473 462 474 463 static struct mipi_dsi_driver jdi_panel_driver = { ··· 467 478 }, 468 479 .probe = jdi_panel_probe, 469 480 .remove = jdi_panel_remove, 470 - .shutdown = jdi_panel_shutdown, 471 481 }; 472 482 module_mipi_dsi_driver(jdi_panel_driver); 473 483