firewire: sbp2: add workarounds for 2nd and 3rd generation iPods

According to https://bugs.launchpad.net/bugs/294391
- 3rd generation iPods need the "fix capacity" workaround after all
(apparently they crash after the last sector was accessed),
- 2nd generation iPods need the "128 kB maximum request size"
workaround.

Alas both iPod generations feature the same model ID in the config ROM,
hence we can only define a shared quirks list entry for them. Luckily
the fix capacity workaround did not show a negative effect in Jarod's
tests with 2nd gen. iPod.

A side note: Apple computers in target mode (or at least an x86 Mac
mini) don't have firmware_version and model_id, hence none of the iPod
quirks list entries is active for them.

Tested-by: Jarod Wilson <jarod@redhat.com>
Acked-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

+9 -7
+9 -7
drivers/firewire/fw-sbp2.c
··· 360 360 .model = SBP2_ROM_VALUE_WILDCARD, 361 361 .workarounds = SBP2_WORKAROUND_128K_MAX_TRANS, 362 362 }, 363 - 364 363 /* 365 - * There are iPods (2nd gen, 3rd gen) with model_id == 0, but 366 - * these iPods do not feature the read_capacity bug according 367 - * to one report. Read_capacity behaviour as well as model_id 368 - * could change due to Apple-supplied firmware updates though. 364 + * iPod 2nd generation: needs 128k max transfer size workaround 365 + * iPod 3rd generation: needs fix capacity workaround 369 366 */ 370 - 371 - /* iPod 4th generation. */ { 367 + { 368 + .firmware_revision = 0x0a2700, 369 + .model = 0x000000, 370 + .workarounds = SBP2_WORKAROUND_128K_MAX_TRANS | 371 + SBP2_WORKAROUND_FIX_CAPACITY, 372 + }, 373 + /* iPod 4th generation */ { 372 374 .firmware_revision = 0x0a2700, 373 375 .model = 0x000021, 374 376 .workarounds = SBP2_WORKAROUND_FIX_CAPACITY,