Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

w1: omap-hdq: fix error return code in omap_hdq_probe()

platform_get_irq() returns an error code, but the omap_hdq
driver ignores it and always returns -ENXIO. This is not correct,
and prevents -EPROBE_DEFER from being propagated properly.
Notice that platform_get_irq() no longer returns 0 on error.

Print error message and propagate the return value of
platform_get_irq on failure.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Gustavo A. R. Silva and committed by
Greg Kroah-Hartman
c89876dd cc84b824

+2 -1
+2 -1
drivers/w1/masters/omap_hdq.c
··· 704 704 705 705 irq = platform_get_irq(pdev, 0); 706 706 if (irq < 0) { 707 - ret = -ENXIO; 707 + dev_dbg(&pdev->dev, "Failed to get IRQ: %d\n", irq); 708 + ret = irq; 708 709 goto err_irq; 709 710 } 710 711