Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

leds: trigger: remove redundant assignment to variable ret

The variable ret is being assigned with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>

authored by

Colin Ian King and committed by
Pavel Machek
c85c7cde 9af512e8

+2 -2
+2 -2
drivers/leds/trigger/ledtrig-timer.c
··· 28 28 { 29 29 struct led_classdev *led_cdev = led_trigger_get_led(dev); 30 30 unsigned long state; 31 - ssize_t ret = -EINVAL; 31 + ssize_t ret; 32 32 33 33 ret = kstrtoul(buf, 10, &state); 34 34 if (ret) ··· 53 53 { 54 54 struct led_classdev *led_cdev = led_trigger_get_led(dev); 55 55 unsigned long state; 56 - ssize_t ret = -EINVAL; 56 + ssize_t ret; 57 57 58 58 ret = kstrtoul(buf, 10, &state); 59 59 if (ret)