Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ARM: spear: replace setup_irq() by request_irq()

request_irq() is preferred over setup_irq(). Invocations of setup_irq()
occur after memory allocators are ready.

Per tglx[1], setup_irq() existed in olden days when allocators were not
ready by the time early interrupts were initialized.

Hence replace setup_irq() by request_irq().

[1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos

Link: https://lore.kernel.org/r/20200327124406.4123-1-afzal.mohd.ma@gmail.com
Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

authored by

afzal mohammed and committed by
Arnd Bergmann
c84e4899 2164f349

+2 -7
+2 -7
arch/arm/mach-spear/time.c
··· 181 181 return IRQ_HANDLED; 182 182 } 183 183 184 - static struct irqaction spear_timer_irq = { 185 - .name = "timer", 186 - .flags = IRQF_TIMER, 187 - .handler = spear_timer_interrupt 188 - }; 189 - 190 184 static void __init spear_clockevent_init(int irq) 191 185 { 192 186 u32 tick_rate; ··· 195 201 196 202 clockevents_config_and_register(&clkevt, tick_rate, 3, 0xfff0); 197 203 198 - setup_irq(irq, &spear_timer_irq); 204 + if (request_irq(irq, spear_timer_interrupt, IRQF_TIMER, "timer", NULL)) 205 + pr_err("Failed to request irq %d (timer)\n", irq); 199 206 } 200 207 201 208 static const struct of_device_id timer_of_match[] __initconst = {