Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

cxgb4: cxgb4_tc_u32: use struct_size() in kvzalloc()

One of the more common cases of allocation size calculations is finding the
size of a structure that has a zero-sized array at the end, along with memory
for some number of elements for that array. For example:

struct foo {
int stuff;
struct boo entry[];
};

instance = kvzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can now
use the new struct_size() helper:

instance = kvzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Gustavo A. R. Silva and committed by
David S. Miller
c829f5f5 9f672984

+1 -2
+1 -2
drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c
··· 444 444 if (!max_tids) 445 445 return NULL; 446 446 447 - t = kvzalloc(sizeof(*t) + 448 - (max_tids * sizeof(struct cxgb4_link)), GFP_KERNEL); 447 + t = kvzalloc(struct_size(t, table, max_tids), GFP_KERNEL); 449 448 if (!t) 450 449 return NULL; 451 450