Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

MIPS: Remove repetitive increase irq_err_count

commit 979934da9e7a ("[PATCH] mips: update IRQ handling for vr41xx") added
a function irq_dispatch, and it'll increase irq_err_count when the get_irq
callback returns a negative value, but increase irq_err_count in get_irq
was not removed.

And also, modpost complains once gpio-vr41xx drivers become modules.
ERROR: modpost: "irq_err_count" [drivers/gpio/gpio-vr41xx.ko] undefined!

So it would be a good idea to remove repetitive increase irq_err_count in
get_irq callback.

Fixes: 27fdd325dace ("MIPS: Update VR41xx GPIO driver to use gpiolib")
Fixes: 979934da9e7a ("[PATCH] mips: update IRQ handling for vr41xx")
Reported-by: k2ci <kernel-bot@kylinos.cn>
Signed-off-by: huhai <huhai@kylinos.cn>
Signed-off-by: Genjian Zhang <zhanggenjian@kylinos.cn>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>

authored by

huhai and committed by
Thomas Bogendoerfer
c81aba8f a111daf0

-4
-2
arch/mips/vr41xx/common/icu.c
··· 640 640 641 641 printk(KERN_ERR "spurious ICU interrupt: %04x,%04x\n", pend1, pend2); 642 642 643 - atomic_inc(&irq_err_count); 644 - 645 643 return -1; 646 644 } 647 645
-2
drivers/gpio/gpio-vr41xx.c
··· 217 217 printk(KERN_ERR "spurious GIU interrupt: %04x(%04x),%04x(%04x)\n", 218 218 maskl, pendl, maskh, pendh); 219 219 220 - atomic_inc(&irq_err_count); 221 - 222 220 return -EINVAL; 223 221 } 224 222