Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

pm2301-charger: Remove unneeded NULL checks

If "pm2" were NULL we would oops printing the error message.
Fortunately, that's not possible so I have removed the NULL checks.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Anton Vorontsov <anton@enomsg.org>

authored by

Dan Carpenter and committed by
Anton Vorontsov
c8024234 ec0b3802

+2 -15
+2 -15
drivers/power/pm2301_charger.c
··· 957 957 { 958 958 struct i2c_client *pm2xxx_i2c_client = to_i2c_client(dev); 959 959 struct pm2xxx_charger *pm2; 960 - int ret = 0; 961 960 962 961 pm2 = (struct pm2xxx_charger *)i2c_get_clientdata(pm2xxx_i2c_client); 963 - if (!pm2) { 964 - dev_err(pm2->dev, "no pm2xxx_charger data supplied\n"); 965 - ret = -EINVAL; 966 - return ret; 967 - } 968 - 969 962 clear_lpn_pin(pm2); 970 963 971 - return ret; 964 + return 0; 972 965 } 973 966 974 967 static int pm2xxx_runtime_resume(struct device *dev) 975 968 { 976 969 struct i2c_client *pm2xxx_i2c_client = to_i2c_client(dev); 977 970 struct pm2xxx_charger *pm2; 978 - int ret = 0; 979 971 980 972 pm2 = (struct pm2xxx_charger *)i2c_get_clientdata(pm2xxx_i2c_client); 981 - if (!pm2) { 982 - dev_err(pm2->dev, "no pm2xxx_charger data supplied\n"); 983 - ret = -EINVAL; 984 - return ret; 985 - } 986 973 987 974 if (gpio_is_valid(pm2->lpn_pin) && gpio_get_value(pm2->lpn_pin) == 0) 988 975 set_lpn_pin(pm2); 989 976 990 - return ret; 977 + return 0; 991 978 } 992 979 993 980 #endif