qed: Add a missing error code · tjh.dev/kernel@c800460

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

qed: Add a missing error code

We should be returning -ENOMEM if qed_mcp_cmd_add_elem() fails. The
current code returns success.

Fixes: 4ed1eea82a21 ("qed: Revise MFW command locking")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Tomer Tayar <Tomer.Tayar@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Dan Carpenter and committed by

David S. Miller 9 years ago c8004600 2c099ccb

+3 -1

1 changed file

expand all

drivers

net

ethernet

qlogic

qed

qed_mcp.c

+3 -1

drivers/net/ethernet/qlogic/qed/qed_mcp.c

··· 455 455 qed_mcp_reread_offsets(p_hwfn, p_ptt); 456 456 seq_num = ++p_hwfn->mcp_info->drv_mb_seq; 457 457 p_cmd_elem = qed_mcp_cmd_add_elem(p_hwfn, p_mb_params, seq_num); 458 - if (!p_cmd_elem) 458 + if (!p_cmd_elem) { 459 + rc = -ENOMEM; 459 460 goto err; 461 + } 460 462 461 463 __qed_mcp_cmd_and_union(p_hwfn, p_ptt, p_mb_params, seq_num); 462 464 spin_unlock_bh(&p_hwfn->mcp_info->cmd_lock);