Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

OMAPFB: remove silly loop in fb2display()

fb2display() has a for loop which always returns at the first iteration.
Replace the loop with a simple if.

This removes the smatch warning:

drivers/video/omap2/omapfb/omapfb.h:153 fb2display() info: loop could be
replaced with if statement.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

+6 -6
+6 -6
drivers/video/omap2/omapfb/omapfb.h
··· 144 144 static inline struct omap_dss_device *fb2display(struct fb_info *fbi) 145 145 { 146 146 struct omapfb_info *ofbi = FB2OFB(fbi); 147 - int i; 147 + struct omap_overlay *ovl; 148 148 149 149 /* XXX: returns the display connected to first attached overlay */ 150 - for (i = 0; i < ofbi->num_overlays; i++) { 151 - struct omap_overlay *ovl = ofbi->overlays[i]; 152 150 153 - return ovl->get_device(ovl); 154 - } 151 + if (ofbi->num_overlays == 0) 152 + return NULL; 155 153 156 - return NULL; 154 + ovl = ofbi->overlays[0]; 155 + 156 + return ovl->get_device(ovl); 157 157 } 158 158 159 159 static inline struct omapfb_display_data *get_display_data(