tjh.dev
Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
drm/exynos: kill mode_set_nofb callback
All Exynos CRTCs are fully configured by .enable callback. The only users
of mode_set_nofb actually did nothing in their callbacks - they immediately
returned because devices were in suspend state - mode_set_nofb is always
called on disabled device.
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
authored by
Andrzej Hajda
and committed by
Inki Dae
c7954aa6
2949390e
-14
-1
drivers/gpu/drm/exynos/exynos7_drm_decon.c
-1
drivers/gpu/drm/exynos/exynos7_drm_decon.c
···
581
581
static const struct exynos_drm_crtc_ops decon_crtc_ops = {
582
582
.enable = decon_enable,
583
583
.disable = decon_disable,
584
-
.commit = decon_commit,
585
584
.enable_vblank = decon_enable_vblank,
586
585
.disable_vblank = decon_disable_vblank,
587
586
.atomic_begin = decon_atomic_begin,
-10
drivers/gpu/drm/exynos/exynos_drm_crtc.c
-10
drivers/gpu/drm/exynos/exynos_drm_crtc.c
···
49
49
}
50
50
}
51
51
52
-
static void
53
-
exynos_drm_crtc_mode_set_nofb(struct drm_crtc *crtc)
54
-
{
55
-
struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(crtc);
56
-
57
-
if (exynos_crtc->ops->commit)
58
-
exynos_crtc->ops->commit(exynos_crtc);
59
-
}
60
-
61
52
static int exynos_crtc_atomic_check(struct drm_crtc *crtc,
62
53
struct drm_crtc_state *state)
63
54
{
···
84
93
static const struct drm_crtc_helper_funcs exynos_crtc_helper_funcs = {
85
94
.enable = exynos_drm_crtc_enable,
86
95
.disable = exynos_drm_crtc_disable,
87
-
.mode_set_nofb = exynos_drm_crtc_mode_set_nofb,
88
96
.atomic_check = exynos_crtc_atomic_check,
89
97
.atomic_begin = exynos_crtc_atomic_begin,
90
98
.atomic_flush = exynos_crtc_atomic_flush,
-2
drivers/gpu/drm/exynos/exynos_drm_drv.h
-2
drivers/gpu/drm/exynos/exynos_drm_drv.h
···
115
115
*
116
116
* @enable: enable the device
117
117
* @disable: disable the device
118
-
* @commit: set current hw specific display mode to hw.
119
118
* @enable_vblank: specific driver callback for enabling vblank interrupt.
120
119
* @disable_vblank: specific driver callback for disabling vblank interrupt.
121
120
* @atomic_check: validate state
···
129
130
struct exynos_drm_crtc_ops {
130
131
void (*enable)(struct exynos_drm_crtc *crtc);
131
132
void (*disable)(struct exynos_drm_crtc *crtc);
132
-
void (*commit)(struct exynos_drm_crtc *crtc);
133
133
int (*enable_vblank)(struct exynos_drm_crtc *crtc);
134
134
void (*disable_vblank)(struct exynos_drm_crtc *crtc);
135
135
u32 (*get_vblank_counter)(struct exynos_drm_crtc *crtc);
-1
drivers/gpu/drm/exynos/exynos_drm_fimd.c
-1
drivers/gpu/drm/exynos/exynos_drm_fimd.c