Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/gud: use new debugfs device-centered functions

Replace the use of drm_debugfs_create_files() with the new
drm_debugfs_add_file() function, which center the debugfs files
management on the drm_device instead of drm_minor. Moreover, remove the
debugfs_init hook and add the debugfs files directly on gud_probe(),
before drm_dev_register().

Signed-off-by: Maíra Canal <mcanal@igalia.com>
Acked-by: Noralf Trønnes <noralf@tronnes.org>
Signed-off-by: Maíra Canal <mairacanal@riseup.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20221226155029.244355-3-mcanal@igalia.com

authored by

Maíra Canal and committed by
Maíra Canal
c702545e d3533a8a

+4 -13
+4 -13
drivers/gpu/drm/gud/gud_drv.c
··· 325 325 326 326 static int gud_stats_debugfs(struct seq_file *m, void *data) 327 327 { 328 - struct drm_info_node *node = m->private; 329 - struct gud_device *gdrm = to_gud_device(node->minor->dev); 328 + struct drm_debugfs_entry *entry = m->private; 329 + struct gud_device *gdrm = to_gud_device(entry->dev); 330 330 char buf[10]; 331 331 332 332 string_get_size(gdrm->bulk_len, 1, STRING_UNITS_2, buf, sizeof(buf)); ··· 350 350 } 351 351 352 352 return 0; 353 - } 354 - 355 - static const struct drm_info_list gud_debugfs_list[] = { 356 - { "stats", gud_stats_debugfs, 0, NULL }, 357 - }; 358 - 359 - static void gud_debugfs_init(struct drm_minor *minor) 360 - { 361 - drm_debugfs_create_files(gud_debugfs_list, ARRAY_SIZE(gud_debugfs_list), 362 - minor->debugfs_root, minor); 363 353 } 364 354 365 355 static const struct drm_simple_display_pipe_funcs gud_pipe_funcs = { ··· 376 386 .fops = &gud_fops, 377 387 DRM_GEM_SHMEM_DRIVER_OPS, 378 388 .gem_prime_import = gud_gem_prime_import, 379 - .debugfs_init = gud_debugfs_init, 380 389 381 390 .name = "gud", 382 391 .desc = "Generic USB Display", ··· 611 622 gdrm->dmadev = usb_intf_get_dma_device(intf); 612 623 if (!gdrm->dmadev) 613 624 dev_warn(dev, "buffer sharing not supported"); 625 + 626 + drm_debugfs_add_file(drm, "stats", gud_stats_debugfs, NULL); 614 627 615 628 ret = drm_dev_register(drm, 0); 616 629 if (ret) {