Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/rockchip: dw_hdmi: use correct SCLIN mask for RK3228

In dw_hdmi_rk3228_setup_hpd(), the SCLIN mask incorrectly references
the RK3328 variant. This change updates it to the RK3228-specific mask
RK3228_HDMI_SCLIN_MSK using FIELD_PREP_WM16, ensuring proper HPD and
I2C pin configuration for RK3228.

Change: RK3328_HDMI_SCLIN_MSK -> RK3228_HDMI_SCLIN_MSK

Fixes: 63df37f3fc71 ("drm/rockchip: dw_hdmi: switch to FIELD_PREP_WM16* macros")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20251010173143.72733-1-alok.a.tiwari@oracle.com

authored by

Alok Tiwari and committed by
Heiko Stuebner
c700e727 5801e652

+1 -1
+1 -1
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
··· 361 361 362 362 regmap_write(hdmi->regmap, RK3228_GRF_SOC_CON2, 363 363 FIELD_PREP_WM16(RK3228_HDMI_SDAIN_MSK, 1) | 364 - FIELD_PREP_WM16(RK3328_HDMI_SCLIN_MSK, 1)); 364 + FIELD_PREP_WM16(RK3228_HDMI_SCLIN_MSK, 1)); 365 365 } 366 366 367 367 static enum drm_connector_status