Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/amdgpu: remove DRM_AMD_POWERPLAY

Powerplay is no longer optional after the recently cleanups

Reviewed-by: Edward O'Callaghan <funfunctor@folklore1984.net>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

+1 -25
-1
drivers/gpu/drm/amd/amdgpu/Kconfig
··· 32 32 Selecting this option creates a debugfs file to inspect the mapped 33 33 pages. Uses more memory for housekeeping, enable only for debugging. 34 34 35 - source "drivers/gpu/drm/amd/powerplay/Kconfig" 36 35 source "drivers/gpu/drm/amd/acp/Kconfig"
-4
drivers/gpu/drm/amd/amdgpu/Makefile
··· 111 111 amdgpu-$(CONFIG_ACPI) += amdgpu_acpi.o 112 112 amdgpu-$(CONFIG_MMU_NOTIFIER) += amdgpu_mn.o 113 113 114 - ifneq ($(CONFIG_DRM_AMD_POWERPLAY),) 115 - 116 114 include $(FULL_AMD_PATH)/powerplay/Makefile 117 115 118 116 amdgpu-y += $(AMD_POWERPLAY_FILES) 119 - 120 - endif 121 117 122 118 obj-$(CONFIG_DRM_AMDGPU)+= amdgpu.o 123 119
-2
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
··· 174 174 MODULE_PARM_DESC(sched_hw_submission, "the max number of HW submissions (default 2)"); 175 175 module_param_named(sched_hw_submission, amdgpu_sched_hw_submission, int, 0444); 176 176 177 - #ifdef CONFIG_DRM_AMD_POWERPLAY 178 177 MODULE_PARM_DESC(powerplay, "Powerplay component (1 = enable, 0 = disable, -1 = auto (default))"); 179 178 module_param_named(powerplay, amdgpu_powerplay, int, 0444); 180 179 ··· 182 183 183 184 MODULE_PARM_DESC(ppfeaturemask, "all power features enabled (default))"); 184 185 module_param_named(ppfeaturemask, amdgpu_pp_feature_mask, int, 0444); 185 - #endif 186 186 187 187 MODULE_PARM_DESC(sclkdeepsleep, "SCLK Deep Sleep (1 = enable (default), 0 = disable)"); 188 188 module_param_named(sclkdeepsleep, amdgpu_sclk_deep_sleep_en, int, 0444);
+1 -12
drivers/gpu/drm/amd/amdgpu/amdgpu_powerplay.c
··· 42 42 amd_pp = &(adev->powerplay); 43 43 44 44 if (adev->pp_enabled) { 45 - #ifdef CONFIG_DRM_AMD_POWERPLAY 46 45 struct amd_pp_init *pp_init; 47 46 48 47 pp_init = kzalloc(sizeof(struct amd_pp_init), GFP_KERNEL); ··· 54 55 pp_init->device = amdgpu_cgs_create_device(adev); 55 56 ret = amd_powerplay_init(pp_init, amd_pp); 56 57 kfree(pp_init); 57 - #endif 58 58 } else { 59 59 amd_pp->pp_handle = (void *)adev; 60 60 ··· 95 97 struct amdgpu_device *adev = (struct amdgpu_device *)handle; 96 98 int ret = 0; 97 99 98 - #ifdef CONFIG_DRM_AMD_POWERPLAY 99 100 switch (adev->asic_type) { 100 101 case CHIP_POLARIS11: 101 102 case CHIP_POLARIS10: ··· 117 120 adev->pp_enabled = false; 118 121 break; 119 122 } 120 - #else 121 - adev->pp_enabled = false; 122 - #endif 123 123 124 124 ret = amdgpu_powerplay_init(adev); 125 125 if (ret) ··· 138 144 ret = adev->powerplay.ip_funcs->late_init( 139 145 adev->powerplay.pp_handle); 140 146 141 - #ifdef CONFIG_DRM_AMD_POWERPLAY 142 147 if (adev->pp_enabled && adev->pm.dpm_enabled) { 143 148 amdgpu_pm_sysfs_init(adev); 144 149 amdgpu_dpm_dispatch_task(adev, AMD_PP_EVENT_COMPLETE_INIT, NULL, NULL); 145 150 } 146 - #endif 151 + 147 152 return ret; 148 153 } 149 154 ··· 155 162 ret = adev->powerplay.ip_funcs->sw_init( 156 163 adev->powerplay.pp_handle); 157 164 158 - #ifdef CONFIG_DRM_AMD_POWERPLAY 159 165 if (adev->pp_enabled) 160 166 adev->pm.dpm_enabled = true; 161 - #endif 162 167 163 168 return ret; 164 169 } ··· 207 216 208 217 static void amdgpu_pp_late_fini(void *handle) 209 218 { 210 - #ifdef CONFIG_DRM_AMD_POWERPLAY 211 219 struct amdgpu_device *adev = (struct amdgpu_device *)handle; 212 220 213 221 if (adev->pp_enabled) { ··· 217 227 if (adev->powerplay.ip_funcs->late_fini) 218 228 adev->powerplay.ip_funcs->late_fini( 219 229 adev->powerplay.pp_handle); 220 - #endif 221 230 } 222 231 223 232 static int amdgpu_pp_suspend(void *handle)
-6
drivers/gpu/drm/amd/powerplay/Kconfig
··· 1 - config DRM_AMD_POWERPLAY 2 - bool "Enable AMD powerplay component" 3 - depends on DRM_AMDGPU 4 - default n 5 - help 6 - select this option will enable AMD powerplay component.