Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: dsa: add tagging driver for MaxLinear GSW1xx switch family

Add support for a new DSA tagging protocol driver for the MaxLinear
GSW1xx switch family. The GSW1xx switches use a proprietary 8-byte
special tag inserted between the source MAC address and the EtherType
field to indicate the source and destination ports for frames
traversing the CPU port.

Implement the tag handling logic to insert the special tag on transmit
and parse it on receive.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Tested-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Link: https://patch.msgid.link/0e973ebfd9433c30c96f50670da9e9449a0d98f2.1762170107.git.daniel@makrotopia.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Daniel Golle and committed by
Jakub Kicinski
c6230446 e1bb4b36

+130 -1
+2 -1
MAINTAINERS
··· 14053 14053 K: landlock 14054 14054 K: LANDLOCK 14055 14055 14056 - LANTIQ / INTEL Ethernet drivers 14056 + LANTIQ / MAXLINEAR / INTEL Ethernet DSA drivers 14057 14057 M: Hauke Mehrtens <hauke@hauke-m.de> 14058 14058 L: netdev@vger.kernel.org 14059 14059 S: Maintained ··· 14061 14061 F: drivers/net/dsa/lantiq/* 14062 14062 F: drivers/net/ethernet/lantiq_xrx200.c 14063 14063 F: net/dsa/tag_gswip.c 14064 + F: net/dsa/tag_mxl-gsw1xx.c 14064 14065 14065 14066 LANTIQ MIPS ARCHITECTURE 14066 14067 M: John Crispin <john@phrozen.org>
+2
include/net/dsa.h
··· 56 56 #define DSA_TAG_PROTO_VSC73XX_8021Q_VALUE 28 57 57 #define DSA_TAG_PROTO_BRCM_LEGACY_FCS_VALUE 29 58 58 #define DSA_TAG_PROTO_YT921X_VALUE 30 59 + #define DSA_TAG_PROTO_MXL_GSW1XX_VALUE 31 59 60 60 61 enum dsa_tag_protocol { 61 62 DSA_TAG_PROTO_NONE = DSA_TAG_PROTO_NONE_VALUE, ··· 90 89 DSA_TAG_PROTO_LAN937X = DSA_TAG_PROTO_LAN937X_VALUE, 91 90 DSA_TAG_PROTO_VSC73XX_8021Q = DSA_TAG_PROTO_VSC73XX_8021Q_VALUE, 92 91 DSA_TAG_PROTO_YT921X = DSA_TAG_PROTO_YT921X_VALUE, 92 + DSA_TAG_PROTO_MXL_GSW1XX = DSA_TAG_PROTO_MXL_GSW1XX_VALUE, 93 93 }; 94 94 95 95 struct dsa_switch;
+1
include/uapi/linux/if_ether.h
··· 92 92 #define ETH_P_ETHERCAT 0x88A4 /* EtherCAT */ 93 93 #define ETH_P_8021AD 0x88A8 /* 802.1ad Service VLAN */ 94 94 #define ETH_P_802_EX1 0x88B5 /* 802.1 Local Experimental 1. */ 95 + #define ETH_P_MXLGSW 0x88C3 /* MaxLinear GSW DSA [ NOT AN OFFICIALLY REGISTERED ID ] */ 95 96 #define ETH_P_PREAUTH 0x88C7 /* 802.11 Preauthentication */ 96 97 #define ETH_P_TIPC 0x88CA /* TIPC */ 97 98 #define ETH_P_LLDP 0x88CC /* Link Layer Discovery Protocol */
+8
net/dsa/Kconfig
··· 104 104 Say Y or M if you want to enable support for tagging frames for 105 105 Mediatek switches. 106 106 107 + config NET_DSA_TAG_MXL_GSW1XX 108 + tristate "Tag driver for MaxLinear GSW1xx switches" 109 + help 110 + The GSW1xx family of switches supports an 8-byte special tag which 111 + can be used on the CPU port of the switch. 112 + Say Y or M if you want to enable support for tagging frames for 113 + MaxLinear GSW1xx switches. 114 + 107 115 config NET_DSA_TAG_KSZ 108 116 tristate "Tag driver for Microchip 8795/937x/9477/9893 families of switches" 109 117 help
+1
net/dsa/Makefile
··· 28 28 obj-$(CONFIG_NET_DSA_TAG_KSZ) += tag_ksz.o 29 29 obj-$(CONFIG_NET_DSA_TAG_LAN9303) += tag_lan9303.o 30 30 obj-$(CONFIG_NET_DSA_TAG_MTK) += tag_mtk.o 31 + obj-$(CONFIG_NET_DSA_TAG_MXL_GSW1XX) += tag_mxl-gsw1xx.o 31 32 obj-$(CONFIG_NET_DSA_TAG_NONE) += tag_none.o 32 33 obj-$(CONFIG_NET_DSA_TAG_OCELOT) += tag_ocelot.o 33 34 obj-$(CONFIG_NET_DSA_TAG_OCELOT_8021Q) += tag_ocelot_8021q.o
+116
net/dsa/tag_mxl-gsw1xx.c
··· 1 + // SPDX-License-Identifier: GPL-2.0+ 2 + /* 3 + * DSA driver Special Tag support for MaxLinear GSW1xx switch chips 4 + * 5 + * Copyright (C) 2025 Daniel Golle <daniel@makrotopia.org> 6 + * Copyright (C) 2023 - 2024 MaxLinear Inc. 7 + */ 8 + 9 + #include <linux/bitops.h> 10 + #include <linux/etherdevice.h> 11 + #include <linux/skbuff.h> 12 + #include <net/dsa.h> 13 + 14 + #include "tag.h" 15 + 16 + /* To define the outgoing port and to discover the incoming port a special 17 + * tag is used by the GSW1xx. 18 + * 19 + * Dest MAC Src MAC special TAG EtherType 20 + * ...| 1 2 3 4 5 6 | 1 2 3 4 5 6 | 1 2 3 4 5 6 7 8 | 1 2 |... 21 + * |<--------------->| 22 + */ 23 + 24 + #define GSW1XX_TAG_NAME "gsw1xx" 25 + 26 + /* special tag header length (RX and TX) */ 27 + #define GSW1XX_HEADER_LEN 8 28 + 29 + /* Word 0 = Ethertype -> 0x88C3 */ 30 + 31 + /* Word 1 */ 32 + #define GSW1XX_TX_PORT_MAP GENMASK(7, 0) 33 + #define GSW1XX_TX_PORT_MAP_EN BIT(15) 34 + #define GSW1XX_TX_CLASS_EN BIT(14) 35 + #define GSW1XX_TX_TIME_STAMP_EN BIT(13) 36 + #define GSW1XX_TX_LRN_DIS BIT(12) 37 + #define GSW1XX_TX_CLASS GENMASK(11, 8) 38 + 39 + /* special tag in RX path header */ 40 + /* Word 2 */ 41 + #define GSW1XX_RX_PORT_MAP GENMASK(15, 8) 42 + 43 + static struct sk_buff *gsw1xx_tag_xmit(struct sk_buff *skb, 44 + struct net_device *dev) 45 + { 46 + struct dsa_port *dp = dsa_user_to_port(dev); 47 + __be16 *gsw1xx_tag; 48 + 49 + /* provide additional space 'GSW1XX_HEADER_LEN' bytes */ 50 + skb_push(skb, GSW1XX_HEADER_LEN); 51 + 52 + /* add space between MAC address and Ethertype */ 53 + dsa_alloc_etype_header(skb, GSW1XX_HEADER_LEN); 54 + 55 + /* special tag ingress */ 56 + gsw1xx_tag = dsa_etype_header_pos_tx(skb); 57 + gsw1xx_tag[0] = htons(ETH_P_MXLGSW); 58 + gsw1xx_tag[1] = htons(GSW1XX_TX_PORT_MAP_EN | GSW1XX_TX_LRN_DIS | 59 + FIELD_PREP(GSW1XX_TX_PORT_MAP, BIT(dp->index))); 60 + 61 + gsw1xx_tag[2] = 0; 62 + gsw1xx_tag[3] = 0; 63 + 64 + return skb; 65 + } 66 + 67 + static struct sk_buff *gsw1xx_tag_rcv(struct sk_buff *skb, 68 + struct net_device *dev) 69 + { 70 + int port; 71 + __be16 *gsw1xx_tag; 72 + 73 + if (unlikely(!pskb_may_pull(skb, GSW1XX_HEADER_LEN))) { 74 + dev_warn_ratelimited(&dev->dev, "Dropping packet, cannot pull SKB\n"); 75 + return NULL; 76 + } 77 + 78 + gsw1xx_tag = dsa_etype_header_pos_rx(skb); 79 + 80 + if (unlikely(ntohs(gsw1xx_tag[0]) != ETH_P_MXLGSW)) { 81 + dev_warn_ratelimited(&dev->dev, "Dropping packet due to invalid special tag\n"); 82 + dev_warn_ratelimited(&dev->dev, "Tag: %8ph\n", gsw1xx_tag); 83 + return NULL; 84 + } 85 + 86 + /* Get source port information */ 87 + port = FIELD_GET(GSW1XX_RX_PORT_MAP, ntohs(gsw1xx_tag[1])); 88 + skb->dev = dsa_conduit_find_user(dev, 0, port); 89 + if (!skb->dev) { 90 + dev_warn_ratelimited(&dev->dev, "Dropping packet due to invalid source port\n"); 91 + dev_warn_ratelimited(&dev->dev, "Tag: %8ph\n", gsw1xx_tag); 92 + return NULL; 93 + } 94 + 95 + /* remove the GSW1xx special tag between MAC addresses and the current 96 + * ethertype field. 97 + */ 98 + skb_pull_rcsum(skb, GSW1XX_HEADER_LEN); 99 + dsa_strip_etype_header(skb, GSW1XX_HEADER_LEN); 100 + 101 + return skb; 102 + } 103 + 104 + static const struct dsa_device_ops gsw1xx_netdev_ops = { 105 + .name = GSW1XX_TAG_NAME, 106 + .proto = DSA_TAG_PROTO_MXL_GSW1XX, 107 + .xmit = gsw1xx_tag_xmit, 108 + .rcv = gsw1xx_tag_rcv, 109 + .needed_headroom = GSW1XX_HEADER_LEN, 110 + }; 111 + 112 + MODULE_DESCRIPTION("DSA tag driver for MaxLinear GSW1xx 8 byte protocol"); 113 + MODULE_LICENSE("GPL"); 114 + MODULE_ALIAS_DSA_TAG_DRIVER(DSA_TAG_PROTO_MXL_GSW1XX, GSW1XX_TAG_NAME); 115 + 116 + module_dsa_tag_driver(gsw1xx_netdev_ops);