Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

irqchip/ls-extirq: add IRQCHIP_SKIP_SET_WAKE to the irqchip flags

The ls-extirq driver doesn't implement the irq_set_wake()
callback, while being wake-up capable. This results in
ugly behaviours across suspend/resume cycles.

Advertise this by adding IRQCHIP_SKIP_SET_WAKE to
the irqchip flags

Fixes: b16a1caf4686 ("irqchip/ls-extirq: Add LS1043A, LS1088A external interrupt support")
Signed-off-by: Biwen Li <biwen.li@nxp.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210129095034.33821-1-biwen.li@oss.nxp.com

authored by

Biwen Li and committed by
Marc Zyngier
c6076742 9eaad15e

+1 -1
+1 -1
drivers/irqchip/irq-ls-extirq.c
··· 64 64 .irq_set_type = ls_extirq_set_type, 65 65 .irq_retrigger = irq_chip_retrigger_hierarchy, 66 66 .irq_set_affinity = irq_chip_set_affinity_parent, 67 - .flags = IRQCHIP_SET_TYPE_MASKED, 67 + .flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_SKIP_SET_WAKE, 68 68 }; 69 69 70 70 static int