Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

uprobes: Re-order struct uprobe_task to save some space

On x86_64, with allmodconfig, struct uprobe_task is 72 bytes long, with a
hole and some padding.

/* size: 72, cachelines: 2, members: 7 */
/* sum members: 64, holes: 1, sum holes: 4 */
/* padding: 4 */
/* forced alignments: 1, forced holes: 1, sum forced holes: 4 */
/* last cacheline: 8 bytes */

Reorder the structure to fill the hole and avoid the padding.

This way, the whole structure fits in a single cacheline and some memory is
saved when it is allocated.

/* size: 64, cachelines: 1, members: 7 */
/* forced alignments: 1 */

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Link: https://lore.kernel.org/r/a9f541d0cedf421f765c77a1fb93d6a979778a88.1730495562.git.christophe.jaillet@wanadoo.fr

authored by

Christophe JAILLET and committed by
Peter Zijlstra
c554aa9c 2e71e8bc

+3 -3
+3 -3
include/linux/uprobes.h
··· 121 121 struct uprobe_task { 122 122 enum uprobe_task_state state; 123 123 124 + unsigned int depth; 125 + struct return_instance *return_instances; 126 + 124 127 union { 125 128 struct { 126 129 struct arch_uprobe_task autask; ··· 141 138 unsigned long xol_vaddr; 142 139 143 140 struct arch_uprobe *auprobe; 144 - 145 - struct return_instance *return_instances; 146 - unsigned int depth; 147 141 }; 148 142 149 143 struct return_consumer {