Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ethernet: manually convert memcpy(dev_addr,..., sizeof(addr))

A handful of drivers use sizeof(addr) for the size of
the address, after manually confirming the size is
indeed 6 convert them to eth_hw_addr_set().

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Petko Manolov <petkan@nucleusys.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

+5 -5
+1 -1
drivers/net/ethernet/cadence/macb_main.c
··· 313 313 addr[5] = (top >> 8) & 0xff; 314 314 315 315 if (is_valid_ether_addr(addr)) { 316 - memcpy(bp->dev->dev_addr, addr, sizeof(addr)); 316 + eth_hw_addr_set(bp->dev, addr); 317 317 return; 318 318 } 319 319 }
+1 -1
drivers/net/ethernet/dnet.c
··· 93 93 *((__be16 *)(addr + 4)) = cpu_to_be16(tmp); 94 94 95 95 if (is_valid_ether_addr(addr)) 96 - memcpy(bp->dev->dev_addr, addr, sizeof(addr)); 96 + eth_hw_addr_set(bp->dev, addr); 97 97 } 98 98 99 99 static int dnet_mdio_read(struct mii_bus *bus, int mii_id, int regnum)
+1 -1
drivers/net/ethernet/pasemi/pasemi_mac.c
··· 1722 1722 err = -ENODEV; 1723 1723 goto out; 1724 1724 } 1725 - memcpy(dev->dev_addr, mac->mac_addr, sizeof(mac->mac_addr)); 1725 + eth_hw_addr_set(dev, mac->mac_addr); 1726 1726 1727 1727 ret = mac_to_intf(mac); 1728 1728 if (ret < 0) {
+1 -1
drivers/net/ethernet/ti/cpmac.c
··· 1112 1112 priv->dev = dev; 1113 1113 priv->ring_size = 64; 1114 1114 priv->msg_enable = netif_msg_init(debug_level, 0xff); 1115 - memcpy(dev->dev_addr, pdata->dev_addr, sizeof(pdata->dev_addr)); 1115 + eth_hw_addr_set(dev, pdata->dev_addr); 1116 1116 1117 1117 snprintf(priv->phy_name, MII_BUS_ID_SIZE, PHY_ID_FMT, 1118 1118 mdio_bus_id, phy_id);
+1 -1
drivers/net/usb/pegasus.c
··· 357 357 goto err; 358 358 } 359 359 360 - memcpy(pegasus->net->dev_addr, node_id, sizeof(node_id)); 360 + eth_hw_addr_set(pegasus->net, node_id); 361 361 362 362 return; 363 363 err: