Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

netfilter: nf_tables: possible module reference underflow in error path

dst->ops is set on when nft_expr_clone() fails, but module refcount has
not been bumped yet, therefore nft_expr_destroy() leads to module
reference underflow.

Fixes: 8cfd9b0f8515 ("netfilter: nftables: generalize set expressions support")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

+1 -1
+1 -1
net/netfilter/nf_tables_api.c
··· 5601 5601 5602 5602 err = nft_expr_clone(expr, set->exprs[i]); 5603 5603 if (err < 0) { 5604 - nft_expr_destroy(ctx, expr); 5604 + kfree(expr); 5605 5605 goto err_expr; 5606 5606 } 5607 5607 expr_array[i] = expr;