Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

x86, apic: Remove mps_oem_check callback

Since commit b5660ba76b41 ("x86, platforms: Remove NUMAQ") removed NUMAQ,
the mps_oem_check() apic callback has been obsolete. Remove it.

This allows generic_mps_oem_check() to be removed as well.

Signed-off-by: David Rientjes <rientjes@google.com>
Link: http://lkml.kernel.org/r/alpine.DEB.2.02.1407302349390.17503@chino.kir.corp.google.com
Signed-off-by: H. Peter Anvin <hpa@zytor.com>

authored by

David Rientjes and committed by
H. Peter Anvin
c460b5d3 300eddf9

+1 -45
-7
arch/x86/include/asm/apic.h
··· 309 309 void (*enable_apic_mode)(void); 310 310 int (*phys_pkg_id)(int cpuid_apic, int index_msb); 311 311 312 - /* 313 - * When one of the next two hooks returns 1 the apic 314 - * is switched to this. Essentially they are additional 315 - * probe functions: 316 - */ 317 - int (*mps_oem_check)(struct mpc_table *mpc, char *oem, char *productid); 318 - 319 312 unsigned int (*get_apic_id)(unsigned long x); 320 313 unsigned long (*set_apic_id)(unsigned int id); 321 314 unsigned long apic_id_mask;
-2
arch/x86/include/asm/mpspec.h
··· 150 150 151 151 extern physid_mask_t phys_cpu_present_map; 152 152 153 - extern int generic_mps_oem_check(struct mpc_table *, char *, char *); 154 - 155 153 #endif /* _ASM_X86_MPSPEC_H */
-2
arch/x86/kernel/apic/apic_flat_64.c
··· 182 182 .check_phys_apicid_present = default_check_phys_apicid_present, 183 183 .enable_apic_mode = NULL, 184 184 .phys_pkg_id = flat_phys_pkg_id, 185 - .mps_oem_check = NULL, 186 185 187 186 .get_apic_id = flat_get_apic_id, 188 187 .set_apic_id = set_apic_id, ··· 294 295 .check_phys_apicid_present = default_check_phys_apicid_present, 295 296 .enable_apic_mode = NULL, 296 297 .phys_pkg_id = flat_phys_pkg_id, 297 - .mps_oem_check = NULL, 298 298 299 299 .get_apic_id = flat_get_apic_id, 300 300 .set_apic_id = set_apic_id,
-2
arch/x86/kernel/apic/apic_noop.c
··· 152 152 153 153 .phys_pkg_id = noop_phys_pkg_id, 154 154 155 - .mps_oem_check = NULL, 156 - 157 155 .get_apic_id = noop_get_apic_id, 158 156 .set_apic_id = NULL, 159 157 .apic_id_mask = 0x0F << 24,
-1
arch/x86/kernel/apic/apic_numachip.c
··· 231 231 .check_phys_apicid_present = default_check_phys_apicid_present, 232 232 .enable_apic_mode = NULL, 233 233 .phys_pkg_id = numachip_phys_pkg_id, 234 - .mps_oem_check = NULL, 235 234 236 235 .get_apic_id = get_apic_id, 237 236 .set_apic_id = set_apic_id,
-1
arch/x86/kernel/apic/bigsmp_32.c
··· 182 182 .check_phys_apicid_present = bigsmp_check_phys_apicid_present, 183 183 .enable_apic_mode = NULL, 184 184 .phys_pkg_id = bigsmp_phys_pkg_id, 185 - .mps_oem_check = NULL, 186 185 187 186 .get_apic_id = bigsmp_get_apic_id, 188 187 .set_apic_id = NULL,
+1 -24
arch/x86/kernel/apic/probe_32.c
··· 102 102 .check_phys_apicid_present = default_check_phys_apicid_present, 103 103 .enable_apic_mode = NULL, 104 104 .phys_pkg_id = default_phys_pkg_id, 105 - .mps_oem_check = NULL, 106 105 107 106 .get_apic_id = default_get_apic_id, 108 107 .set_apic_id = NULL, ··· 209 210 printk(KERN_INFO "Using APIC driver %s\n", apic->name); 210 211 } 211 212 212 - /* These functions can switch the APIC even after the initial ->probe() */ 213 - 214 - int __init 215 - generic_mps_oem_check(struct mpc_table *mpc, char *oem, char *productid) 216 - { 217 - struct apic **drv; 218 - 219 - for (drv = __apicdrivers; drv < __apicdrivers_end; drv++) { 220 - if (!((*drv)->mps_oem_check)) 221 - continue; 222 - if (!(*drv)->mps_oem_check(mpc, oem, productid)) 223 - continue; 224 - 225 - if (!cmdline_apic) { 226 - apic = *drv; 227 - printk(KERN_INFO "Switched to APIC driver `%s'.\n", 228 - apic->name); 229 - } 230 - return 1; 231 - } 232 - return 0; 233 - } 234 - 213 + /* This function can switch the APIC even after the initial ->probe() */ 235 214 int __init default_acpi_madt_oem_check(char *oem_id, char *oem_table_id) 236 215 { 237 216 struct apic **drv;
-1
arch/x86/kernel/apic/x2apic_cluster.c
··· 263 263 .check_phys_apicid_present = default_check_phys_apicid_present, 264 264 .enable_apic_mode = NULL, 265 265 .phys_pkg_id = x2apic_phys_pkg_id, 266 - .mps_oem_check = NULL, 267 266 268 267 .get_apic_id = x2apic_get_apic_id, 269 268 .set_apic_id = x2apic_set_apic_id,
-1
arch/x86/kernel/apic/x2apic_phys.c
··· 117 117 .check_phys_apicid_present = default_check_phys_apicid_present, 118 118 .enable_apic_mode = NULL, 119 119 .phys_pkg_id = x2apic_phys_pkg_id, 120 - .mps_oem_check = NULL, 121 120 122 121 .get_apic_id = x2apic_get_apic_id, 123 122 .set_apic_id = x2apic_set_apic_id,
-1
arch/x86/kernel/apic/x2apic_uv_x.c
··· 379 379 .check_phys_apicid_present = default_check_phys_apicid_present, 380 380 .enable_apic_mode = NULL, 381 381 .phys_pkg_id = uv_phys_pkg_id, 382 - .mps_oem_check = NULL, 383 382 384 383 .get_apic_id = x2apic_get_apic_id, 385 384 .set_apic_id = set_apic_id,
-3
arch/x86/kernel/mpparse.c
··· 216 216 if (!smp_check_mpc(mpc, oem, str)) 217 217 return 0; 218 218 219 - #ifdef CONFIG_X86_32 220 - generic_mps_oem_check(mpc, oem, str); 221 - #endif 222 219 /* Initialize the lapic mapping */ 223 220 if (!acpi_lapic) 224 221 register_lapic_address(mpc->lapic);