Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: ddbridge/sx8: remove redundant check of iq_mode == 2

The check for irq_mode == 2 occurs is always false and hence flags
is always zero. This is because the check occurs in a path where
irq_mode is >= 3. Clean up the code by removing the check and irq_mode
and just pass 0.

Detected by CoverityScan, CID#1472214 ("Logically dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: Ralph Metzler <rjkm@metzlerbros.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

authored by

Colin Ian King and committed by
Mauro Carvalho Chehab
c4189ffb 99117f54

+1 -3
+1 -3
drivers/media/pci/ddbridge/ddbridge-sx8.c
··· 398 398 } 399 399 stat = start(fe, 3, mask, ts_config); 400 400 } else { 401 - u32 flags = (iq_mode == 2) ? 1 : 0; 402 - 403 - stat = start_iq(fe, flags, 4, ts_config); 401 + stat = start_iq(fe, 0, 4, ts_config); 404 402 } 405 403 if (!stat) { 406 404 state->started = 1;