Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork

Configure Feed

Select the types of activity you want to include in your feed.

[SCSI] qla2xxx: Properly set the tagging for commands.

This fixes a regression where Xyratex controllers and disks were lost by the
driver:

https://bugzilla.kernel.org/show_bug.cgi?id=59601

Reported-by: Jack Hill <jackhill@jackhill.us>
Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

authored by

Saurav Kashyap and committed by
James Bottomley
c3ccb1d7 96f15f29

+9 -2
+9 -2
drivers/scsi/qla2xxx/qla_iocb.c
··· 419 419 __constant_cpu_to_le16(CF_SIMPLE_TAG); 420 420 break; 421 421 } 422 + } else { 423 + cmd_pkt->control_flags = __constant_cpu_to_le16(CF_SIMPLE_TAG); 422 424 } 423 425 424 426 /* Load SCSI command packet. */ ··· 1309 1307 fcp_cmnd->task_attribute = TSK_ORDERED; 1310 1308 break; 1311 1309 default: 1312 - fcp_cmnd->task_attribute = 0; 1310 + fcp_cmnd->task_attribute = TSK_SIMPLE; 1313 1311 break; 1314 1312 } 1315 1313 } else { 1316 - fcp_cmnd->task_attribute = 0; 1314 + fcp_cmnd->task_attribute = TSK_SIMPLE; 1317 1315 } 1318 1316 1319 1317 cmd_pkt->fcp_rsp_dseg_len = 0; /* Let response come in status iocb */ ··· 1527 1525 case ORDERED_QUEUE_TAG: 1528 1526 cmd_pkt->task = TSK_ORDERED; 1529 1527 break; 1528 + default: 1529 + cmd_pkt->task = TSK_SIMPLE; 1530 + break; 1530 1531 } 1532 + } else { 1533 + cmd_pkt->task = TSK_SIMPLE; 1531 1534 } 1532 1535 1533 1536 /* Load SCSI command packet. */