Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

sfc_ef100: Drop redundant pci_disable_pcie_error_reporting()

51b35a454efd ("sfc: skeleton EF100 PF driver") added a call to
pci_disable_pcie_error_reporting() in ef100_pci_remove().

Remove this call since there's no apparent reason to disable error
reporting when it was not previously enabled.

Note that since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core enables PCIe error reporting for all devices during
enumeration, so the driver doesn't need to do it itself.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Martin Habets <habetsm.xilinx@gmail.com>
Acked-by: Edward Cree <ecree.xilinx@gmail.com>
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Bjorn Helgaas and committed by
Jakub Kicinski
c39abdd3 ecded61c

-3
-3
drivers/net/ethernet/sfc/ef100.c
··· 11 11 12 12 #include "net_driver.h" 13 13 #include <linux/module.h> 14 - #include <linux/aer.h> 15 14 #include "efx_common.h" 16 15 #include "efx_channels.h" 17 16 #include "io.h" ··· 438 439 efx_fini_io(efx); 439 440 440 441 pci_dbg(pci_dev, "shutdown successful\n"); 441 - 442 - pci_disable_pcie_error_reporting(pci_dev); 443 442 444 443 pci_set_drvdata(pci_dev, NULL); 445 444 efx_fini_struct(efx);