Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: phy: tja11xx: replace deprecated strncpy with ethtool_sprintf

strncpy() is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.

ethtool_sprintf() is designed specifically for get_strings() usage.
Let's replace strncpy in favor of this dedicated helper function.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
Link: https://github.com/KSPP/linux/issues/90
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20231012-strncpy-drivers-net-phy-nxp-tja11xx-c-v1-1-5ad6c9dff5c4@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Justin Stitt and committed by
Jakub Kicinski
c3983d5e ad0ebd8b

+2 -4
+2 -4
drivers/net/phy/nxp-tja11xx.c
··· 414 414 { 415 415 int i; 416 416 417 - for (i = 0; i < ARRAY_SIZE(tja11xx_hw_stats); i++) { 418 - strncpy(data + i * ETH_GSTRING_LEN, 419 - tja11xx_hw_stats[i].string, ETH_GSTRING_LEN); 420 - } 417 + for (i = 0; i < ARRAY_SIZE(tja11xx_hw_stats); i++) 418 + ethtool_sprintf(&data, "%s", tja11xx_hw_stats[i].string); 421 419 } 422 420 423 421 static void tja11xx_get_stats(struct phy_device *phydev,