Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

soundwire: use consistent format for Slave devID logs

We mix decimal and hexadecimal values, this leads to confusions in
dmesg logs and bug reports. Let's add a 0x prefix for all hexadecimal
values and a format when more than 4 bits are used.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20210115053738.22630-2-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Pierre-Louis Bossart and committed by
Vinod Koul
c397efb7 ee3db942

+6 -9
+2 -3
drivers/soundwire/bus.c
··· 679 679 id->class_id = SDW_CLASS_ID(addr); 680 680 681 681 dev_dbg(bus->dev, 682 - "SDW Slave class_id %x, part_id %x, mfg_id %x, unique_id %x, version %x\n", 683 - id->class_id, id->part_id, id->mfg_id, 684 - id->unique_id, id->sdw_version); 682 + "SDW Slave class_id 0x%02x, mfg_id 0x%04x, part_id 0x%04x, unique_id 0x%x, version 0x%x\n", 683 + id->class_id, id->mfg_id, id->part_id, id->unique_id, id->sdw_version); 685 684 } 686 685 687 686 static int sdw_program_device_num(struct sdw_bus *bus)
+4 -6
drivers/soundwire/slave.c
··· 163 163 164 164 if (id.unique_id != id2.unique_id) { 165 165 dev_dbg(bus->dev, 166 - "Valid unique IDs %x %x for Slave mfg %x part %d\n", 167 - id.unique_id, id2.unique_id, 168 - id.mfg_id, id.part_id); 166 + "Valid unique IDs 0x%x 0x%x for Slave mfg_id 0x%04x, part_id 0x%04x\n", 167 + id.unique_id, id2.unique_id, id.mfg_id, id.part_id); 169 168 ignore_unique_id = false; 170 169 } else { 171 170 dev_err(bus->dev, 172 - "Invalid unique IDs %x %x for Slave mfg %x part %d\n", 173 - id.unique_id, id2.unique_id, 174 - id.mfg_id, id.part_id); 171 + "Invalid unique IDs 0x%x 0x%x for Slave mfg_id 0x%04x, part_id 0x%04x\n", 172 + id.unique_id, id2.unique_id, id.mfg_id, id.part_id); 175 173 return -ENODEV; 176 174 } 177 175 }