Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[SCSI] ses: Use vpd information from scsi_device

The scsi_device now has VPD page83 information attached, so
there is no need to query it again.

Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

authored by

Hannes Reinecke and committed by
James Bottomley
c38c007a b3ae8780

+10 -28
+10 -28
drivers/scsi/ses.c
··· 25 25 #include <linux/module.h> 26 26 #include <linux/kernel.h> 27 27 #include <linux/enclosure.h> 28 + #include <asm/unaligned.h> 28 29 29 30 #include <scsi/scsi.h> 30 31 #include <scsi/scsi_cmnd.h> ··· 449 448 static void ses_match_to_enclosure(struct enclosure_device *edev, 450 449 struct scsi_device *sdev) 451 450 { 452 - unsigned char *buf; 453 451 unsigned char *desc; 454 - unsigned int vpd_len; 455 452 struct efd efd = { 456 453 .addr = 0, 457 454 }; 458 455 459 - buf = kmalloc(INIT_ALLOC_SIZE, GFP_KERNEL); 460 - if (!buf || scsi_get_vpd_page(sdev, 0x83, buf, INIT_ALLOC_SIZE)) 461 - goto free; 462 - 463 456 ses_enclosure_data_process(edev, to_scsi_device(edev->edev.parent), 0); 464 457 465 - vpd_len = ((buf[2] << 8) | buf[3]) + 4; 466 - kfree(buf); 467 - buf = kmalloc(vpd_len, GFP_KERNEL); 468 - if (!buf ||scsi_get_vpd_page(sdev, 0x83, buf, vpd_len)) 469 - goto free; 458 + if (!sdev->vpd_pg83_len) 459 + return; 470 460 471 - desc = buf + 4; 472 - while (desc < buf + vpd_len) { 461 + desc = sdev->vpd_pg83 + 4; 462 + while (desc < sdev->vpd_pg83 + sdev->vpd_pg83_len) { 473 463 enum scsi_protocol proto = desc[0] >> 4; 474 464 u8 code_set = desc[0] & 0x0f; 475 465 u8 piv = desc[1] & 0x80; ··· 470 478 471 479 if (piv && code_set == 1 && assoc == 1 472 480 && proto == SCSI_PROTOCOL_SAS && type == 3 && len == 8) 473 - efd.addr = (u64)desc[4] << 56 | 474 - (u64)desc[5] << 48 | 475 - (u64)desc[6] << 40 | 476 - (u64)desc[7] << 32 | 477 - (u64)desc[8] << 24 | 478 - (u64)desc[9] << 16 | 479 - (u64)desc[10] << 8 | 480 - (u64)desc[11]; 481 + efd.addr = get_unaligned_be64(&desc[4]); 481 482 482 483 desc += len + 4; 483 484 } 484 - if (!efd.addr) 485 - goto free; 485 + if (efd.addr) { 486 + efd.dev = &sdev->sdev_gendev; 486 487 487 - efd.dev = &sdev->sdev_gendev; 488 - 489 - enclosure_for_each_device(ses_enclosure_find_by_addr, &efd); 490 - free: 491 - kfree(buf); 488 + enclosure_for_each_device(ses_enclosure_find_by_addr, &efd); 489 + } 492 490 } 493 491 494 492 static int ses_intf_add(struct device *cdev,