Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: wfx: remove false positive warning

When a station is removed, the driver check that all the Tx frames were
correctly sent. However, the station can be removed before all the Tx
frames were acknowledged and a false positive warning can be emitted.

The previous commit has added a trace when driver received an
acknowledge for a non-existent station. It appear that these events
are perfectly correlated and there is no leak.

Now, the subject is perfectly understood. Remove the warning. Just keep
a debug trace in case we have any doubt in the future.

In the past, the subject has already been discussed here:
https://lore.kernel.org/driverdev-devel/6287924.ghGFUMk3OD@pc-42/

Fixes: 4bbc6a3e7ad0 ("staging: wfx: make warning about pending frame less scary")
Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20200515083325.378539-20-Jerome.Pouiller@silabs.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Jérôme Pouiller and committed by
Greg Kroah-Hartman
c336c022 07d51346

+4 -2
+4 -2
drivers/staging/wfx/sta.c
··· 441 441 442 442 for (i = 0; i < ARRAY_SIZE(sta_priv->buffered); i++) 443 443 if (sta_priv->buffered[i]) 444 - dev_warn(wvif->wdev->dev, "release station while %d pending frame on queue %d", 445 - sta_priv->buffered[i], i); 444 + // Not an error if paired with trace in 445 + // wfx_tx_update_sta() 446 + dev_dbg(wvif->wdev->dev, "release station while %d pending frame on queue %d", 447 + sta_priv->buffered[i], i); 446 448 // See note in wfx_sta_add() 447 449 if (!sta_priv->link_id) 448 450 return 0;