Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ipack: Fail earlier for drivers without probe function

A driver without a probe function isn't useful as it can never be used.
Let registering such a driver fail already instead of failing every
binding.

This is only cosmetic as there is no ipack driver without a probe function.

Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Acked-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Link: https://lore.kernel.org/r/20210207215556.96371-1-uwe@kleine-koenig.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Uwe Kleine-König and committed by
Greg Kroah-Hartman
c31d32ba e3e3eaab

+3 -3
+3 -3
drivers/ipack/ipack.c
··· 64 64 struct ipack_device *dev = to_ipack_dev(device); 65 65 struct ipack_driver *drv = to_ipack_driver(device->driver); 66 66 67 - if (!drv->ops->probe) 68 - return -EINVAL; 69 - 70 67 return drv->ops->probe(dev); 71 68 } 72 69 ··· 249 252 int ipack_driver_register(struct ipack_driver *edrv, struct module *owner, 250 253 const char *name) 251 254 { 255 + if (!edrv->ops->probe) 256 + return -EINVAL; 257 + 252 258 edrv->driver.owner = owner; 253 259 edrv->driver.name = name; 254 260 edrv->driver.bus = &ipack_bus_type;