Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: ethernet: mtk_wed: Fix NULL vs IS_ERR() bug in mtk_wed_get_memory_region()

We recently changed this from using devm_ioremap() to using
devm_ioremap_resource() and unfortunately the former returns NULL while
the latter returns error pointers. The check for errors needs to be
updated as well.

Fixes: e27dba1951ce ("net: Use of_reserved_mem_region_to_resource{_byname}() for "memory-region"")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Link: https://patch.msgid.link/87c10dbd-df86-4971-b4f5-40ba02c076fb@sabinyo.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Dan Carpenter and committed by
Jakub Kicinski
c2fe3b2a 1e5e40f2

+3 -1
+3 -1
drivers/net/ethernet/mediatek/mtk_wed_mcu.c
··· 247 247 region->phy_addr = res.start; 248 248 region->size = resource_size(&res); 249 249 region->addr = devm_ioremap_resource(hw->dev, &res); 250 + if (IS_ERR(region->addr)) 251 + return PTR_ERR(region->addr); 250 252 251 - return !region->addr ? -EINVAL : 0; 253 + return 0; 252 254 } 253 255 254 256 static int