Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork

Configure Feed

Select the types of activity you want to include in your feed.

sata_sil24: freeze on non-dev errors reported via CERR

CERR reports errors detected during executing a command. This doesn't
mean the error is tied to the command and can be recovered by just
issuing it again. Many of the errors are fatal port-wide connditions
including HSM violation, host bus error and ATA bus error and require
freezing and port reset.

The freezing part wasn't implemented previously. This used to be okay
because port resets were scheduled anyway and EH eventually resets and
recovers the port. With PMP support added, this is no longer true.
The error condition and recover actions are attributed to the fan-out
port and the host port condition isn't properly recovered leading to
EH failures.

This patch makes CERR errors which require resets to freeze the port.
This will force host port reset and proper recovery.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Andrew Ryder <tireman@shaw.ca>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

authored by

Tejun Heo and committed by
Jeff Garzik
c2e14f11 7293fa8f

+3
+3
drivers/ata/sata_sil24.c
··· 1094 1094 if (ci && ci->desc) { 1095 1095 err_mask |= ci->err_mask; 1096 1096 action |= ci->action; 1097 + if (action & ATA_EH_RESET_MASK) 1098 + freeze = 1; 1097 1099 ata_ehi_push_desc(ehi, "%s", ci->desc); 1098 1100 } else { 1099 1101 err_mask |= AC_ERR_OTHER; 1100 1102 action |= ATA_EH_SOFTRESET; 1103 + freeze = 1; 1101 1104 ata_ehi_push_desc(ehi, "unknown command error %d", 1102 1105 cerr); 1103 1106 }