Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

extcon: max14577: fix handling return value of regmap_irq_get_virq

The function can return negative values, so its result should
be assigned to signed variable.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

authored by

Andrzej Hajda and committed by
Chanwoo Choi
c2957563 36e2693b

+1 -1
+1 -1
drivers/extcon/extcon-max14577.c
··· 692 692 /* Support irq domain for max14577 MUIC device */ 693 693 for (i = 0; i < info->muic_irqs_num; i++) { 694 694 struct max14577_muic_irq *muic_irq = &info->muic_irqs[i]; 695 - unsigned int virq = 0; 695 + int virq = 0; 696 696 697 697 virq = regmap_irq_get_virq(max14577->irq_data, muic_irq->irq); 698 698 if (virq <= 0)