Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fs/drop_caches.c: avoid softlockups in drop_pagecache_sb()

When superblock has lots of inodes without any pagecache (like is the
case for /proc), drop_pagecache_sb() will iterate through all of them
without dropping sb->s_inode_list_lock which can lead to softlockups
(one of our customers hit this).

Fix the problem by going to the slow path and doing cond_resched() in
case the process needs rescheduling.

Link: http://lkml.kernel.org/r/20190114085343.15011-1-jack@suse.cz
Signed-off-by: Jan Kara <jack@suse.cz>
Acked-by: Michal Hocko <mhocko@suse.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Jan Kara and committed by
Linus Torvalds
c27d82f5 e0a352fa

+7 -1
+7 -1
fs/drop_caches.c
··· 21 21 spin_lock(&sb->s_inode_list_lock); 22 22 list_for_each_entry(inode, &sb->s_inodes, i_sb_list) { 23 23 spin_lock(&inode->i_lock); 24 + /* 25 + * We must skip inodes in unusual state. We may also skip 26 + * inodes without pages but we deliberately won't in case 27 + * we need to reschedule to avoid softlockups. 28 + */ 24 29 if ((inode->i_state & (I_FREEING|I_WILL_FREE|I_NEW)) || 25 - (inode->i_mapping->nrpages == 0)) { 30 + (inode->i_mapping->nrpages == 0 && !need_resched())) { 26 31 spin_unlock(&inode->i_lock); 27 32 continue; 28 33 } ··· 35 30 spin_unlock(&inode->i_lock); 36 31 spin_unlock(&sb->s_inode_list_lock); 37 32 33 + cond_resched(); 38 34 invalidate_mapping_pages(inode->i_mapping, 0, -1); 39 35 iput(toput_inode); 40 36 toput_inode = inode;