Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

tty: hvcs: Drop unnecessary if block

If hvcs_probe() succeeded dev_set_drvdata() is called with a non-NULL
value, and if hvcs_probe() failed hvcs_remove() isn't called.

So there is no way dev_get_drvdata() can return NULL in hvcs_remove() and
the check can just go away.

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20210114175718.137483-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Uwe Kleine-König and committed by
Greg Kroah-Hartman
c24dc4ba 9335e23d

-3
-3
drivers/tty/hvc/hvcs.c
··· 825 825 unsigned long flags; 826 826 struct tty_struct *tty; 827 827 828 - if (!hvcsd) 829 - return -ENODEV; 830 - 831 828 /* By this time the vty-server won't be getting any more interrupts */ 832 829 833 830 spin_lock_irqsave(&hvcsd->lock, flags);