Input: turbografx - fix potential out of bound access

Patch 17dd3f0f7aa7: "[PATCH] drivers/input/joystick: convert to dynamic
input_dev allocation" from Sep 15, 2005, leads to the following static
checker warning:

drivers/input/joystick/turbografx.c:235 tgfx_probe()
error: buffer overflow 'tgfx_buttons' 5 <= 5

drivers/input/joystick/turbografx.c
195 for (i = 0; i < n_devs; i++) {
196 if (n_buttons[i] < 1)
197 continue;
198
199 if (n_buttons[i] > 6) {
^^^^^^^^^^^^^^^^
Possibly off by one. >= 6.

Let's change the upper value to ARRAY_SIZE(tgfx_buttons) to ensure we do
not reach past the end of the array.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

+1 -1
+1 -1
drivers/input/joystick/turbografx.c
··· 196 if (n_buttons[i] < 1) 197 continue; 198 199 - if (n_buttons[i] > 6) { 200 printk(KERN_ERR "turbografx.c: Invalid number of buttons %d\n", n_buttons[i]); 201 err = -EINVAL; 202 goto err_unreg_devs;
··· 196 if (n_buttons[i] < 1) 197 continue; 198 199 + if (n_buttons[i] > ARRAY_SIZE(tgfx_buttons)) { 200 printk(KERN_ERR "turbografx.c: Invalid number of buttons %d\n", n_buttons[i]); 201 err = -EINVAL; 202 goto err_unreg_devs;