Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/i915: Rename GT_STEP to GRAPHICS_STEP

As now graphics and media can have different steppings this patch is
renaming all _GT_STEP macros to _GRAPHICS_STEP.

Future platforms will properly choose between _MEDIA_STEP and
_GRAPHICS_STEP for each new workaround.

Cc: Matt Atwood <matthew.s.atwood@intel.com>
Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Caz Yokoyama <caz.yokoyama@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211020002353.193893-3-jose.souza@intel.com

+51 -52
+1 -1
drivers/gpu/drm/i915/gt/gen8_engine_cs.c
··· 42 42 vf_flush_wa = true; 43 43 44 44 /* WaForGAMHang:kbl */ 45 - if (IS_KBL_GT_STEP(rq->engine->i915, 0, STEP_C0)) 45 + if (IS_KBL_GRAPHICS_STEP(rq->engine->i915, 0, STEP_C0)) 46 46 dc_flush_wa = true; 47 47 } 48 48
+1 -1
drivers/gpu/drm/i915/gt/intel_mocs.c
··· 424 424 425 425 table->unused_entries_index = I915_MOCS_PTE; 426 426 if (IS_DG2(i915)) { 427 - if (IS_DG2_GT_STEP(i915, G10, STEP_A0, STEP_B0)) { 427 + if (IS_DG2_GRAPHICS_STEP(i915, G10, STEP_A0, STEP_B0)) { 428 428 table->size = ARRAY_SIZE(dg2_mocs_table_g10_ax); 429 429 table->table = dg2_mocs_table_g10_ax; 430 430 } else {
+1 -1
drivers/gpu/drm/i915/gt/intel_region_lmem.c
··· 158 158 static bool get_legacy_lowmem_region(struct intel_uncore *uncore, 159 159 u64 *start, u32 *size) 160 160 { 161 - if (!IS_DG1_GT_STEP(uncore->i915, STEP_A0, STEP_C0)) 161 + if (!IS_DG1_GRAPHICS_STEP(uncore->i915, STEP_A0, STEP_C0)) 162 162 return false; 163 163 164 164 *start = 0;
+15 -16
drivers/gpu/drm/i915/gt/intel_workarounds.c
··· 482 482 gen9_ctx_workarounds_init(engine, wal); 483 483 484 484 /* WaToEnableHwFixForPushConstHWBug:kbl */ 485 - if (IS_KBL_GT_STEP(i915, STEP_C0, STEP_FOREVER)) 485 + if (IS_KBL_GRAPHICS_STEP(i915, STEP_C0, STEP_FOREVER)) 486 486 wa_masked_en(wal, COMMON_SLICE_CHICKEN2, 487 487 GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION); 488 488 ··· 957 957 GEN8_EU_GAUNIT_CLOCK_GATE_DISABLE); 958 958 959 959 /* WaInPlaceDecompressionHang:skl */ 960 - if (IS_SKL_GT_STEP(gt->i915, STEP_A0, STEP_H0)) 960 + if (IS_SKL_GRAPHICS_STEP(gt->i915, STEP_A0, STEP_H0)) 961 961 wa_write_or(wal, 962 962 GEN9_GAMT_ECO_REG_RW_IA, 963 963 GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS); ··· 969 969 gen9_gt_workarounds_init(gt, wal); 970 970 971 971 /* WaDisableDynamicCreditSharing:kbl */ 972 - if (IS_KBL_GT_STEP(gt->i915, 0, STEP_C0)) 972 + if (IS_KBL_GRAPHICS_STEP(gt->i915, 0, STEP_C0)) 973 973 wa_write_or(wal, 974 974 GAMT_CHKN_BIT_REG, 975 975 GAMT_CHKN_DISABLE_DYNAMIC_CREDIT_SHARING); ··· 1177 1177 1178 1178 /* Wa_1607087056:icl,ehl,jsl */ 1179 1179 if (IS_ICELAKE(i915) || 1180 - IS_JSL_EHL_GT_STEP(i915, STEP_A0, STEP_B0)) 1180 + IS_JSL_EHL_GRAPHICS_STEP(i915, STEP_A0, STEP_B0)) 1181 1181 wa_write_or(wal, 1182 1182 SLICE_UNIT_LEVEL_CLKGATE, 1183 1183 L3_CLKGATE_DIS | L3_CR2X_CLKGATE_DIS); ··· 1231 1231 gen12_gt_workarounds_init(gt, wal); 1232 1232 1233 1233 /* Wa_1409420604:tgl */ 1234 - if (IS_TGL_UY_GT_STEP(i915, STEP_A0, STEP_B0)) 1234 + if (IS_TGL_UY_GRAPHICS_STEP(i915, STEP_A0, STEP_B0)) 1235 1235 wa_write_or(wal, 1236 1236 SUBSLICE_UNIT_LEVEL_CLKGATE2, 1237 1237 CPSSUNIT_CLKGATE_DIS); 1238 1238 1239 1239 /* Wa_1607087056:tgl also know as BUG:1409180338 */ 1240 - if (IS_TGL_UY_GT_STEP(i915, STEP_A0, STEP_B0)) 1240 + if (IS_TGL_UY_GRAPHICS_STEP(i915, STEP_A0, STEP_B0)) 1241 1241 wa_write_or(wal, 1242 1242 SLICE_UNIT_LEVEL_CLKGATE, 1243 1243 L3_CLKGATE_DIS | L3_CR2X_CLKGATE_DIS); 1244 1244 1245 1245 /* Wa_1408615072:tgl[a0] */ 1246 - if (IS_TGL_UY_GT_STEP(i915, STEP_A0, STEP_B0)) 1246 + if (IS_TGL_UY_GRAPHICS_STEP(i915, STEP_A0, STEP_B0)) 1247 1247 wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE2, 1248 1248 VSUNIT_CLKGATE_DIS_TGL); 1249 1249 } ··· 1256 1256 gen12_gt_workarounds_init(gt, wal); 1257 1257 1258 1258 /* Wa_1607087056:dg1 */ 1259 - if (IS_DG1_GT_STEP(i915, STEP_A0, STEP_B0)) 1259 + if (IS_DG1_GRAPHICS_STEP(i915, STEP_A0, STEP_B0)) 1260 1260 wa_write_or(wal, 1261 1261 SLICE_UNIT_LEVEL_CLKGATE, 1262 1262 L3_CLKGATE_DIS | L3_CR2X_CLKGATE_DIS); ··· 1664 1664 tgl_whitelist_build(engine); 1665 1665 1666 1666 /* GEN:BUG:1409280441:dg1 */ 1667 - if (IS_DG1_GT_STEP(engine->i915, STEP_A0, STEP_B0) && 1667 + if (IS_DG1_GRAPHICS_STEP(engine->i915, STEP_A0, STEP_B0) && 1668 1668 (engine->class == RENDER_CLASS || 1669 1669 engine->class == COPY_ENGINE_CLASS)) 1670 1670 whitelist_reg_ext(w, RING_ID(engine->mmio_base), ··· 1757 1757 { 1758 1758 struct drm_i915_private *i915 = engine->i915; 1759 1759 1760 - if (IS_DG1_GT_STEP(i915, STEP_A0, STEP_B0) || 1761 - IS_TGL_UY_GT_STEP(i915, STEP_A0, STEP_B0)) { 1760 + if (IS_DG1_GRAPHICS_STEP(i915, STEP_A0, STEP_B0) || 1761 + IS_TGL_UY_GRAPHICS_STEP(i915, STEP_A0, STEP_B0)) { 1762 1762 /* 1763 1763 * Wa_1607138336:tgl[a0],dg1[a0] 1764 1764 * Wa_1607063988:tgl[a0],dg1[a0] ··· 1768 1768 GEN12_DISABLE_POSH_BUSY_FF_DOP_CG); 1769 1769 } 1770 1770 1771 - if (IS_TGL_UY_GT_STEP(i915, STEP_A0, STEP_B0)) { 1771 + if (IS_TGL_UY_GRAPHICS_STEP(i915, STEP_A0, STEP_B0)) { 1772 1772 /* 1773 1773 * Wa_1606679103:tgl 1774 1774 * (see also Wa_1606682166:icl) ··· 1803 1803 } 1804 1804 1805 1805 if (IS_ALDERLAKE_P(i915) || IS_ALDERLAKE_S(i915) || 1806 - IS_DG1_GT_STEP(i915, STEP_A0, STEP_B0) || 1806 + IS_DG1_GRAPHICS_STEP(i915, STEP_A0, STEP_B0) || 1807 1807 IS_ROCKETLAKE(i915) || IS_TIGERLAKE(i915)) { 1808 1808 /* Wa_1409804808:tgl,rkl,dg1[a0],adl-s,adl-p */ 1809 1809 wa_masked_en(wal, GEN7_ROW_CHICKEN2, ··· 1816 1816 wa_masked_en(wal, GEN9_ROW_CHICKEN4, GEN12_DISABLE_TDL_PUSH); 1817 1817 } 1818 1818 1819 - 1820 - if (IS_DG1_GT_STEP(i915, STEP_A0, STEP_B0) || 1819 + if (IS_DG1_GRAPHICS_STEP(i915, STEP_A0, STEP_B0) || 1821 1820 IS_ROCKETLAKE(i915) || IS_TIGERLAKE(i915)) { 1822 1821 /* 1823 1822 * Wa_1607030317:tgl ··· 2178 2179 struct drm_i915_private *i915 = engine->i915; 2179 2180 2180 2181 /* WaKBLVECSSemaphoreWaitPoll:kbl */ 2181 - if (IS_KBL_GT_STEP(i915, STEP_A0, STEP_F0)) { 2182 + if (IS_KBL_GRAPHICS_STEP(i915, STEP_A0, STEP_F0)) { 2182 2183 wa_write(wal, 2183 2184 RING_SEMA_WAIT_POLL(engine->mmio_base), 2184 2185 1);
+23 -23
drivers/gpu/drm/i915/i915_drv.h
··· 1346 1346 #define HAS_DSB(dev_priv) (INTEL_INFO(dev_priv)->display.has_dsb) 1347 1347 1348 1348 #define INTEL_DISPLAY_STEP(__i915) (RUNTIME_INFO(__i915)->step.display_step) 1349 - #define INTEL_GT_STEP(__i915) (RUNTIME_INFO(__i915)->step.gt_step) 1349 + #define INTEL_GRAPHICS_STEP(__i915) (RUNTIME_INFO(__i915)->step.graphics_step) 1350 1350 #define INTEL_MEDIA_STEP(__i915) (RUNTIME_INFO(__i915)->step.media_step) 1351 1351 1352 1352 #define IS_DISPLAY_STEP(__i915, since, until) \ 1353 1353 (drm_WARN_ON(&(__i915)->drm, INTEL_DISPLAY_STEP(__i915) == STEP_NONE), \ 1354 1354 INTEL_DISPLAY_STEP(__i915) >= (since) && INTEL_DISPLAY_STEP(__i915) < (until)) 1355 1355 1356 - #define IS_GT_STEP(__i915, since, until) \ 1357 - (drm_WARN_ON(&(__i915)->drm, INTEL_GT_STEP(__i915) == STEP_NONE), \ 1358 - INTEL_GT_STEP(__i915) >= (since) && INTEL_GT_STEP(__i915) < (until)) 1356 + #define IS_GRAPHICS_STEP(__i915, since, until) \ 1357 + (drm_WARN_ON(&(__i915)->drm, INTEL_GRAPHICS_STEP(__i915) == STEP_NONE), \ 1358 + INTEL_GRAPHICS_STEP(__i915) >= (since) && INTEL_GRAPHICS_STEP(__i915) < (until)) 1359 1359 1360 1360 #define IS_MEDIA_STEP(__i915, since, until) \ 1361 1361 (drm_WARN_ON(&(__i915)->drm, INTEL_MEDIA_STEP(__i915) == STEP_NONE), \ ··· 1533 1533 #define IS_TGL_Y(dev_priv) \ 1534 1534 IS_SUBPLATFORM(dev_priv, INTEL_TIGERLAKE, INTEL_SUBPLATFORM_ULX) 1535 1535 1536 - #define IS_SKL_GT_STEP(p, since, until) (IS_SKYLAKE(p) && IS_GT_STEP(p, since, until)) 1536 + #define IS_SKL_GRAPHICS_STEP(p, since, until) (IS_SKYLAKE(p) && IS_GRAPHICS_STEP(p, since, until)) 1537 1537 1538 - #define IS_KBL_GT_STEP(dev_priv, since, until) \ 1539 - (IS_KABYLAKE(dev_priv) && IS_GT_STEP(dev_priv, since, until)) 1538 + #define IS_KBL_GRAPHICS_STEP(dev_priv, since, until) \ 1539 + (IS_KABYLAKE(dev_priv) && IS_GRAPHICS_STEP(dev_priv, since, until)) 1540 1540 #define IS_KBL_DISPLAY_STEP(dev_priv, since, until) \ 1541 1541 (IS_KABYLAKE(dev_priv) && IS_DISPLAY_STEP(dev_priv, since, until)) 1542 1542 1543 - #define IS_JSL_EHL_GT_STEP(p, since, until) \ 1544 - (IS_JSL_EHL(p) && IS_GT_STEP(p, since, until)) 1543 + #define IS_JSL_EHL_GRAPHICS_STEP(p, since, until) \ 1544 + (IS_JSL_EHL(p) && IS_GRAPHICS_STEP(p, since, until)) 1545 1545 #define IS_JSL_EHL_DISPLAY_STEP(p, since, until) \ 1546 1546 (IS_JSL_EHL(p) && IS_DISPLAY_STEP(p, since, until)) 1547 1547 ··· 1549 1549 (IS_TIGERLAKE(__i915) && \ 1550 1550 IS_DISPLAY_STEP(__i915, since, until)) 1551 1551 1552 - #define IS_TGL_UY_GT_STEP(__i915, since, until) \ 1552 + #define IS_TGL_UY_GRAPHICS_STEP(__i915, since, until) \ 1553 1553 ((IS_TGL_U(__i915) || IS_TGL_Y(__i915)) && \ 1554 - IS_GT_STEP(__i915, since, until)) 1554 + IS_GRAPHICS_STEP(__i915, since, until)) 1555 1555 1556 - #define IS_TGL_GT_STEP(__i915, since, until) \ 1556 + #define IS_TGL_GRAPHICS_STEP(__i915, since, until) \ 1557 1557 (IS_TIGERLAKE(__i915) && !(IS_TGL_U(__i915) || IS_TGL_Y(__i915)) && \ 1558 - IS_GT_STEP(__i915, since, until)) 1558 + IS_GRAPHICS_STEP(__i915, since, until)) 1559 1559 1560 1560 #define IS_RKL_DISPLAY_STEP(p, since, until) \ 1561 1561 (IS_ROCKETLAKE(p) && IS_DISPLAY_STEP(p, since, until)) 1562 1562 1563 - #define IS_DG1_GT_STEP(p, since, until) \ 1564 - (IS_DG1(p) && IS_GT_STEP(p, since, until)) 1563 + #define IS_DG1_GRAPHICS_STEP(p, since, until) \ 1564 + (IS_DG1(p) && IS_GRAPHICS_STEP(p, since, until)) 1565 1565 #define IS_DG1_DISPLAY_STEP(p, since, until) \ 1566 1566 (IS_DG1(p) && IS_DISPLAY_STEP(p, since, until)) 1567 1567 ··· 1569 1569 (IS_ALDERLAKE_S(__i915) && \ 1570 1570 IS_DISPLAY_STEP(__i915, since, until)) 1571 1571 1572 - #define IS_ADLS_GT_STEP(__i915, since, until) \ 1572 + #define IS_ADLS_GRAPHICS_STEP(__i915, since, until) \ 1573 1573 (IS_ALDERLAKE_S(__i915) && \ 1574 - IS_GT_STEP(__i915, since, until)) 1574 + IS_GRAPHICS_STEP(__i915, since, until)) 1575 1575 1576 1576 #define IS_ADLP_DISPLAY_STEP(__i915, since, until) \ 1577 1577 (IS_ALDERLAKE_P(__i915) && \ 1578 1578 IS_DISPLAY_STEP(__i915, since, until)) 1579 1579 1580 - #define IS_ADLP_GT_STEP(__i915, since, until) \ 1580 + #define IS_ADLP_GRAPHICS_STEP(__i915, since, until) \ 1581 1581 (IS_ALDERLAKE_P(__i915) && \ 1582 - IS_GT_STEP(__i915, since, until)) 1582 + IS_GRAPHICS_STEP(__i915, since, until)) 1583 1583 1584 - #define IS_XEHPSDV_GT_STEP(__i915, since, until) \ 1585 - (IS_XEHPSDV(__i915) && IS_GT_STEP(__i915, since, until)) 1584 + #define IS_XEHPSDV_GRAPHICS_STEP(__i915, since, until) \ 1585 + (IS_XEHPSDV(__i915) && IS_GRAPHICS_STEP(__i915, since, until)) 1586 1586 1587 1587 /* 1588 1588 * DG2 hardware steppings are a bit unusual. The hardware design was forked ··· 1598 1598 * and stepping-specific logic will be applied with a general DG2-wide stepping 1599 1599 * number. 1600 1600 */ 1601 - #define IS_DG2_GT_STEP(__i915, variant, since, until) \ 1601 + #define IS_DG2_GRAPHICS_STEP(__i915, variant, since, until) \ 1602 1602 (IS_SUBPLATFORM(__i915, INTEL_DG2, INTEL_SUBPLATFORM_##variant) && \ 1603 - IS_GT_STEP(__i915, since, until)) 1603 + IS_GRAPHICS_STEP(__i915, since, until)) 1604 1604 1605 1605 #define IS_DG2_DISP_STEP(__i915, since, until) \ 1606 1606 (IS_DG2(__i915) && \
+3 -3
drivers/gpu/drm/i915/intel_pm.c
··· 7461 7461 gen12lp_init_clock_gating(dev_priv); 7462 7462 7463 7463 /* Wa_1409836686:dg1[a0] */ 7464 - if (IS_DG1_GT_STEP(dev_priv, STEP_A0, STEP_B0)) 7464 + if (IS_DG1_GRAPHICS_STEP(dev_priv, STEP_A0, STEP_B0)) 7465 7465 intel_uncore_write(&dev_priv->uncore, GEN9_CLKGATE_DIS_3, intel_uncore_read(&dev_priv->uncore, GEN9_CLKGATE_DIS_3) | 7466 7466 DPT_GATING_DIS); 7467 7467 } ··· 7509 7509 FBC_LLC_FULLY_OPEN); 7510 7510 7511 7511 /* WaDisableSDEUnitClockGating:kbl */ 7512 - if (IS_KBL_GT_STEP(dev_priv, 0, STEP_C0)) 7512 + if (IS_KBL_GRAPHICS_STEP(dev_priv, 0, STEP_C0)) 7513 7513 intel_uncore_write(&dev_priv->uncore, GEN8_UCGCTL6, intel_uncore_read(&dev_priv->uncore, GEN8_UCGCTL6) | 7514 7514 GEN8_SDEUNIT_CLOCK_GATE_DISABLE); 7515 7515 7516 7516 /* WaDisableGamClockGating:kbl */ 7517 - if (IS_KBL_GT_STEP(dev_priv, 0, STEP_C0)) 7517 + if (IS_KBL_GRAPHICS_STEP(dev_priv, 0, STEP_C0)) 7518 7518 intel_uncore_write(&dev_priv->uncore, GEN6_UCGCTL1, intel_uncore_read(&dev_priv->uncore, GEN6_UCGCTL1) | 7519 7519 GEN6_GAMUNIT_CLOCK_GATE_DISABLE); 7520 7520
+6 -6
drivers/gpu/drm/i915/intel_step.c
··· 23 23 * use a macro to define these to make it easier to identify the platforms 24 24 * where the two steppings can deviate. 25 25 */ 26 - #define COMMON_STEP(x) .gt_step = STEP_##x, .display_step = STEP_##x, .media_step = STEP_##x 27 - #define COMMON_GT_MEDIA_STEP(x) .gt_step = STEP_##x, .media_step = STEP_##x 26 + #define COMMON_STEP(x) .graphics_step = STEP_##x, .display_step = STEP_##x, .media_step = STEP_##x 27 + #define COMMON_GT_MEDIA_STEP(x) .graphics_step = STEP_##x, .media_step = STEP_##x 28 28 29 29 static const struct intel_step_info skl_revids[] = { 30 30 [0x6] = { COMMON_STEP(G0) }, ··· 180 180 if (!revids) 181 181 return; 182 182 183 - if (revid < size && revids[revid].gt_step != STEP_NONE) { 183 + if (revid < size && revids[revid].graphics_step != STEP_NONE) { 184 184 step = revids[revid]; 185 185 } else { 186 186 drm_warn(&i915->drm, "Unknown revid 0x%02x\n", revid); ··· 193 193 * steppings in the array are not monotonically increasing, but 194 194 * it's better than defaulting to 0. 195 195 */ 196 - while (revid < size && revids[revid].gt_step == STEP_NONE) 196 + while (revid < size && revids[revid].graphics_step == STEP_NONE) 197 197 revid++; 198 198 199 199 if (revid < size) { ··· 202 202 step = revids[revid]; 203 203 } else { 204 204 drm_dbg(&i915->drm, "Using future steppings\n"); 205 - step.gt_step = STEP_FUTURE; 205 + step.graphics_step = STEP_FUTURE; 206 206 step.display_step = STEP_FUTURE; 207 207 } 208 208 } 209 209 210 - if (drm_WARN_ON(&i915->drm, step.gt_step == STEP_NONE)) 210 + if (drm_WARN_ON(&i915->drm, step.graphics_step == STEP_NONE)) 211 211 return; 212 212 213 213 RUNTIME_INFO(i915)->step = step;
+1 -1
drivers/gpu/drm/i915/intel_step.h
··· 11 11 struct drm_i915_private; 12 12 13 13 struct intel_step_info { 14 - u8 gt_step; 14 + u8 graphics_step; 15 15 u8 display_step; 16 16 u8 media_step; 17 17 };